fix: remoteLoader pure functional on browser env#1085
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/ByMcnwrmEX3WeqyaS8GG3HtGr9jg |
320ecd8 to
dc0c935
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
- Coverage 82.91% 81.88% -1.04%
==========================================
Files 54 56 +2
Lines 1639 1678 +39
Branches 448 458 +10
==========================================
+ Hits 1359 1374 +15
- Misses 163 182 +19
- Partials 117 122 +5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fine tunning of #1080, now we release a new package @lingui/remote-loader, instead of using the @lingui/loader.
Loader dependencies are so much oriented to node environments, for a safer usage and extendability I decided to extract the remoteLoader to a new package with esm, and cjs exports usable on node and browser.
Pending to add documentatio to this new tool, the API it's simple: