feat(message-utils): make generateMessageId to be working in browser#1776
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1776 +/- ##
==========================================
+ Coverage 76.24% 76.27% +0.03%
==========================================
Files 81 81
Lines 2071 2074 +3
Branches 528 529 +1
==========================================
+ Hits 1579 1582 +3
Misses 380 380
Partials 112 112
☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Oct 4, 2023
44 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is some demand to compile catalogs and messages on the fly. The
generateMessageIdfunction used nodejs api before, and it makes it not possible to use in the browser. There is a native WebCrypro api which supported in both browser and nodejs, but unfortunately it's async only and could not be used in babel macros transformation which is synchronous.I've used a custom js sha256 implementation, which is according to theirs benchmark fast as a native implementation.
Also i did not like that tests for
compileMessageFunction is stored somewhere else, so i extracted them fromapipackage.Types of changes
Fixes # (issue)
Checklist