feat: support compile and extract with multi thread#2313
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I was very close to do it by myself, so thanks for the handling that. I have a few questions though:
Also could you elaborate a bit about most notable changes, considerations, difficulties. to have more context for review. From my side, i believe it's possible to implement for custom extractor as well, i will spent some time to tackle this. |
|
|
@Zxilly i'll take it from here, thanks for contribution. |
|
I will also continue working on this patch. Perhaps we can standardize the way workers are handled? Or add more unit tests? I'll see what I can do. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I closed all other PR's and reopened this one. Here is my comment from other PR;
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
- Coverage 77.05% 76.17% -0.88%
==========================================
Files 84 99 +15
Lines 2157 2636 +479
Branches 555 685 +130
==========================================
+ Hits 1662 2008 +346
- Misses 382 504 +122
- Partials 113 124 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Regarding the coverage - coverage is not gathered for worker files, it seems they are not get instrumented since they are spawned in a separate thread. The other files just extracted from existing places, so coverage level was not changed for them. |
|
https://github.com/bcoe/c8 This may be helpful for coverage collection. |
f549843 to
60c03ab
Compare
Description
Offload the task to
worker_threadto utilize the computing power of multiple cores.Types of changes
This is a follow up of #2299
Checklist