-
Notifications
You must be signed in to change notification settings - Fork 48
Replace Travis with GitHub Actions #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
===========================================
- Coverage 82.22% 71.77% -10.45%
===========================================
Files 22 22
Lines 8069 4043 -4026
===========================================
- Hits 6635 2902 -3733
+ Misses 1434 1141 -293
Continue to review full report at Codecov.
|
c334a5e
to
b0462ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good but why the sharp drop in coverage? 🤔
I'm dumbfounded by that too. 🤷♂️ |
Why switch away from Travis? |
@goofballLogic, there are many reasons, but the most important one is that Travis has stopped notifying GitHub (see travis-ci/travis-ci#10204) so instead of fixing Travis, I think it's better to just replace it with GitHub Actions. |
That is very sad, but reading the background it appears to be the right call. I think we should have an issue for this to track the decision making process? |
@goofballLogic, sure. I've created #50. |
An approval of this PR would be highly appreciated, @tpluscode, @goofballLogic. 😅 |
Don't we need to fix the test coverage? |
As the test coverage reduction has nothing to do with this PR, there's nothing I can or will do about it in this PR. That's not to say we shouldn't do anything about it ever, it's just completely unrelated to this PR, which we need to get merged to even get code coverage reporting working again. :) |
ok i guess we just disable the check for now... |
The code coverage check isn't required to pass, so there's no need to disable it. Thanks for the approval, @goofballLogic! |
Replace Travis with GitHub Actions. Resolved #50.