Skip to content

Replace Travis with GitHub Actions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020
Merged

Conversation

asbjornu
Copy link
Member

@asbjornu asbjornu commented May 4, 2020

Replace Travis with GitHub Actions. Resolved #50.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #44 into master will decrease coverage by 10.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #44       +/-   ##
===========================================
- Coverage   82.22%   71.77%   -10.45%     
===========================================
  Files          22       22               
  Lines        8069     4043     -4026     
===========================================
- Hits         6635     2902     -3733     
+ Misses       1434     1141      -293     
Impacted Files Coverage Δ
src/json-ld.net/Impl/NQuadRDFParser.cs 50.00% <0.00%> (-50.00%) ⬇️
src/json-ld.net/Impl/TurtleRDFParser.cs 64.80% <0.00%> (-33.83%) ⬇️
src/json-ld.net/Core/JsonLdProcessor.cs 73.62% <0.00%> (-23.49%) ⬇️
src/json-ld.net/Core/JsonLdSet.cs 77.77% <0.00%> (-22.23%) ⬇️
src/json-ld.net/Core/JsonLdOptions.cs 78.04% <0.00%> (-21.96%) ⬇️
src/json-ld.net/Core/RDFDatasetUtils.cs 56.41% <0.00%> (-16.86%) ⬇️
src/json-ld.net/Util/URL.cs 87.19% <0.00%> (-12.81%) ⬇️
src/json-ld.net/Core/JsonLdApi.cs 87.88% <0.00%> (-9.61%) ⬇️
src/json-ld.net/Util/JavaCompat.cs 75.83% <0.00%> (-7.41%) ⬇️
src/json-ld.net/Util/Obj.cs 21.73% <0.00%> (-6.39%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb4271...a219860. Read the comment docs.

@asbjornu asbjornu force-pushed the feature/github-actions branch from c334a5e to b0462ad Compare May 4, 2020 10:09
@asbjornu asbjornu marked this pull request as ready for review May 4, 2020 10:13
Copy link
Collaborator

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but why the sharp drop in coverage? 🤔

@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

Looking good but why the sharp drop in coverage? 🤔

I'm dumbfounded by that too. 🤷‍♂️

@goofballLogic
Copy link
Member

Why switch away from Travis?

@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

@goofballLogic, there are many reasons, but the most important one is that Travis has stopped notifying GitHub (see travis-ci/travis-ci#10204) so instead of fixing Travis, I think it's better to just replace it with GitHub Actions.

@goofballLogic
Copy link
Member

That is very sad, but reading the background it appears to be the right call. I think we should have an issue for this to track the decision making process?

@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

@goofballLogic, sure. I've created #50.

@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

An approval of this PR would be highly appreciated, @tpluscode, @goofballLogic. 😅

@goofballLogic
Copy link
Member

Don't we need to fix the test coverage?

@asbjornu asbjornu requested a review from tpluscode May 4, 2020 12:51
@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

Don't we need to fix the test coverage?

As the test coverage reduction has nothing to do with this PR, there's nothing I can or will do about it in this PR. That's not to say we shouldn't do anything about it ever, it's just completely unrelated to this PR, which we need to get merged to even get code coverage reporting working again. :)

@goofballLogic
Copy link
Member

ok i guess we just disable the check for now...

@asbjornu
Copy link
Member Author

asbjornu commented May 4, 2020

The code coverage check isn't required to pass, so there's no need to disable it. Thanks for the approval, @goofballLogic!

@asbjornu asbjornu merged commit cad6be1 into master May 4, 2020
@asbjornu asbjornu deleted the feature/github-actions branch May 4, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Travis with GitHub Actions
3 participants