Skip to content

Add basic usage documentation - readme #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 30, 2020
Merged

Conversation

goofballLogic
Copy link
Member

@goofballLogic goofballLogic commented Jul 2, 2020

First steps for #11. Note that other PRs will follow to provide example use cases (samples).

@goofballLogic goofballLogic marked this pull request as draft July 2, 2020 13:42
@goofballLogic goofballLogic requested a review from asbjornu July 2, 2020 13:42
@goofballLogic goofballLogic self-assigned this Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   68.59%   68.59%           
=======================================
  Files          22       22           
  Lines        4053     4053           
  Branches     1028     1028           
=======================================
  Hits         2780     2780           
  Misses       1130     1130           
  Partials      143      143           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98b12f...7450cc2. Read the comment docs.

@goofballLogic goofballLogic linked an issue Jul 2, 2020 that may be closed by this pull request
@goofballLogic goofballLogic changed the title Update readme.md with basic documentation from jsonld.js Add basic usage documentation Jul 2, 2020
@goofballLogic goofballLogic changed the title Add basic usage documentation Add basic usage documentation - readme Jul 2, 2020
@goofballLogic
Copy link
Member Author

@asbjornu is this heading in the right direction?

@goofballLogic
Copy link
Member Author

Codecov appears to be borked for this PR. Do you know anything about codecov @asbjornu / @wattsm ?

@asbjornu
Copy link
Member

asbjornu commented Jul 2, 2020

This is awesome! Just mark it as done once you're ready for a review.

I'll take a look at Codecov once time allows. It's not set up as a required check yet, so we can ignore it until it's in 100% working order.

@goofballLogic goofballLogic removed the request for review from asbjornu July 3, 2020 10:09
@goofballLogic goofballLogic force-pushed the feature/documentation branch from f7d6cfc to 00c05ef Compare July 5, 2020 09:42
@goofballLogic goofballLogic marked this pull request as ready for review July 5, 2020 09:44
@goofballLogic goofballLogic requested a review from asbjornu July 5, 2020 09:44
@goofballLogic
Copy link
Member Author

All code added to the org here: https://github.com/linked-data-dotnet/json-ld.net-Demo

@asbjornu if you feel it shouldn't be in the organisation I will remove it again. Was looking for some way to make it easier to update the README in future.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great first start! Awesome work, @goofballLogic!

I know it hasn't been discussed, but I think Remark defines a great set of both guidelines and tools to keep Markdown documents in good shape. Now that we are adding quite a bit of Markdown to this repository, I think it would be good to standardize on formatting rules and commit them to the repository. Since that isn't done yet, I would still like to address some of the things I care about and that Remark (by default) is going to complain about anyway.

All code added to the org here: https://github.com/linked-data-dotnet/json-ld.net-Demo

Awesome!

@asbjornu if you feel it shouldn't be in the organisation I will remove it again. Was looking for some way to make it easier to update the README in future.

Two thumbs up from me! 👍 👍

goofballLogic and others added 13 commits July 7, 2020 21:47
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
goofballLogic and others added 5 commits July 7, 2020 22:27
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
Co-authored-by: Asbjørn Ulsberg <[email protected]>
@goofballLogic
Copy link
Member Author

Have added basic descriptions of the various algorithms and utility methods

@goofballLogic goofballLogic requested a review from asbjornu July 7, 2020 22:12
@goofballLogic
Copy link
Member Author

I will squash most of the commits once you are happy with the outcome @asbjornu

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic work, @goofballLogic! Thanks for investing the time necessary to get this done.

I think we need to strike a balance here between our personal preferences and discouraging contributions from others.

I agree.

When considering what makes it easier "to read as plain text", I think it very much depends what you are using to access the text. Certain editors, terminals and shells do a good job of providing line wrapping facilities, and manual line wrapping can sometimes prevent users taking advantage of the facilities at their disposal. On the other hand there are the line-oriented editors and piping tools (I happen to be a fan of vi) which benefit from short discrete lines.

Yes, I think plain text rendering benefits from an 80 character limit, if only to reduce the line length to a readable amount.

I don't mind doing the work but I do think we need to settle on a reasonably small set of well documented rules for contributors to follow. I would like to see more community involvement in this project going forward if possible.

I find that most developers mimicking the style used already, unless they are completely unfamilar with Markdown, in which case any standard could be seen as a benefit or hindrance.

I'll go ahead and make the changes suggested, but can you think about putting together a short guide for contributors?

Yes, absolutely: #70

Is the requirement to alter the code itself to adhere to a 80 character limit also? Some of these code examples will need a bit of an overhaul to fit within that narrow limit if so...

No, it only applies to text written in natural language.

same applies for the link references - I'm not sure how to keep those to 80 characters as the URLs are longer than that limit in some cases. Maybe there's some markdown black magic for this?

No, that's one of the many positives about using link references instead of inline links, as you can just have as long links as you'd like down at the bottom of the file without affecting readability one ounce.

@goofballLogic goofballLogic merged commit 25fcbdd into master Jul 30, 2020
@goofballLogic goofballLogic deleted the feature/documentation branch July 30, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples missing
2 participants