Skip to content

Fix CLIPVisionModel hidden_states issue in Llava convergence test for transformers v5 #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tcc0403 merged 1 commit into from
Feb 7, 2026
Merged

Fix CLIPVisionModel hidden_states issue in Llava convergence test for transformers v5 #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,11 +620,12 @@ def revert_liger_kernel_to_llava(model_config: MiniModelConfig):
Revert all Liger kernel patches applied to llava.
"""

from transformers.models.clip import modeling_clip
from transformers.models.llama import modeling_llama
from transformers.models.llava import modeling_llava

importlib.reload(modeling_clip)
# Note: Do NOT reload modeling_clip as it breaks CLIPVisionModel's
# output_hidden_states functionality in transformers v5.
# Liger kernel does not patch modeling_clip when model=None.
importlib.reload(modeling_llava)
importlib.reload(modeling_llama)

Expand Down