feat(inject): support arbitrary proxy parameters from helm #12493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/inject-h2-server
branch
from
2e9dede to
14ec2f1
Compare
New proxy HTTP2 server parameters can be configured from the environment. These
environment variables take the form:
LINKERD2_PROXY_[INBOUND|OUTBOUND]_[SERVER]_[HTTP2]_<PARAM>
We want to allow these parameters to be set, i.e., in a values.yaml file without
having to document all of the possible parameters (especially those that
primarily influence internals not exposed to the application).
To accomodate this, this commit introduces generic proxy environment templating
and a test to verify the behavior.
Values like the following:
proxy:
inbound:
scope:
proto:
blueberryPi: 3.14
outbound:
scope:
proto:
applesauce: "valueA"
Manifest as a proxy environment including:
LINKERD2_PROXY_INBOUND_SCOPE_PROTO_BLUEBERRY_PI="3.14"
LINKERD2_PROXY_OUTBOUND_SCOPE_PROTO_APPLESAUCE=valueA
That is, Helm value keys are converted to SCREAMING_SNAKE_CASE environment
variable names.
olix0r
force-pushed
the
ver/inject-h2-server
branch
from
14ec2f1 to
24f3de2
Compare
olix0r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New proxy HTTP2 server parameters can be configured from the environment. These environment variables take the form:
We want to allow these parameters to be set, i.e., in a values.yaml file without having to document all of the possible parameters (especially those that primarily influence internals not exposed to the application).
To accomodate this, this commit introduces generic proxy environment templating and a test to verify the behavior.
Values like the following:
Manifest as a proxy environment including:
That is, Helm value keys are converted to SCREAMING_SNAKE_CASE environment variable names.