refactor(helm): Replace VFS with embed for Helm chart rendering #14206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
adleong
changed the title
alpeb
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
This is beyond awesome! 💯
I confirmed it fixes #13873 :
# build the CLI in the main branch
$ rm target/cli/linux-amd64/linkerd
$ bin/build-cli-bin
$ sha256sum target/cli/linux-amd64/linkerd
6c70cbf6eabc8375bd085d11d4f01a2e2c6d7bbbdf54981c92db48ee4d2b6272 target/cli/linux-amd64/linkerd
# fetch charts again so the files timestamps change
$ rm -rf charts/
$ git checkout .
$ rm -rf target/cli/linux-amd64/linkerd
$ bin/build-cli-bin
# FILE CONTENTS HAVE CHANGED
$ sha256sum target/cli/linux-amd64/linkerd
2b95a8d78e2a52d71dd3f4f8d3b4bd5573b4927405cb278a3e27a01d2b9667f4 target/cli/linux-amd64/linkerd
# Let's do the same using the current branch
$ git checkout alex/template-prototype
$ rm target/cli/linux-amd64/linkerd
$ bin/build-cli-bin
$ sha256sum target/cli/linux-amd64/linkerd
582b5f47454e961a6c3c9736e8e1971c4463c94f9a361dd358b94b8be9112906 target/cli/linux-amd64/linkerd
# fetch charts again so the files timestamps change
$ rm -rf charts/
$ git checkout .
$ rm -rf target/cli/linux-amd64/linkerd
$ bin/build-cli-bin
# FILE CONTENTS HAVE ** NOT ** CHANGED!
$ sha256sum target/cli/linux-amd64/linkerd
582b5f47454e961a6c3c9736e8e1971c4463c94f9a361dd358b94b8be9112906 target/cli/linux-amd64/linkerd
olix0r
approved these changes
Jul 13, 2025
adleong
added a commit
that referenced
this pull request
Jul 24, 2025
…#14206)" This reverts commit e3ea351. Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the static FS generated by the vfs package with the go embed directive. These are the same in concept, except that the go embed directive is performed automatically by the go build system at build time instead of requiring a separate
go generatestep. Therefore this allows us to remove our use ofgo generateand avoids needing to manage generated sources.