chore(charts): Add separate namespace field for trace collector service account #14539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Sep 26, 2025
olix0r
reviewed
Sep 26, 2025
| meshIdentity: | ||
| # -- Service account name for the trace collector. For most cases, this will be | ||
| # "<collector service name>.<namespace>", e.g. For a service `collector` in the `monitoring` namespace, | ||
| # this should be set to `collector.monitoring`. |
There was a problem hiding this comment.
It would be great if we had an optional serviceAccountNamespace to be consistent so that we weren't overloading serviceAccountName syntax
There was a problem hiding this comment.
Thinking on this, it's probably better to just have it required if the user wants tracing since the collector has to be meshed anyway. I've updated the values and goldens for this.
This clarifies the tracing documentation that the trace collector must be meshed, along with the specifics of how the service account name for the collector should be set. Signed-off-by: Scott Fleener <[email protected]>
This separates out the service account namespace from the name to make it clearer how to set the correct service account for the trace collector. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/tracing-docs
branch
from
84e194a to
5b22d29
Compare
…lector mesh identity Signed-off-by: Scott Fleener <[email protected]>
sfleen
changed the title
olix0r
approved these changes
Sep 30, 2025
adleong
reviewed
Sep 30, 2025
sfleen
changed the title
Signed-off-by: Scott Fleener <[email protected]>
…e fields Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
adleong
approved these changes
Oct 1, 2025
olix0r
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also splits out the namespace for the service account into a separate field to make it much easier for the trace collector to be configured properly.
This also clarifies the tracing documentation that the trace collector must be meshed, along with the specifics of how the service account for the collector should be set.