chore(tests): Separate tracing tests from viz #14547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
commented
Sep 29, 2025
There was a problem hiding this comment.
We should probably pin the jaeger and otel collector versions in the test values files, not sure if there's a way to make dependabot pick those up when they're not in the usual places (lockfiles, etc.).
There was a problem hiding this comment.
I agree that we should pin versions for reproducibility. Even if dependabot doesn't know about them and we have to bump them manually whenever we want to test against a new version of the tracing architecture.
sfleen
force-pushed
the
sfleen/tracing-tests
branch
from
186e70d to
95b82e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Now that the proxy has tracing configuration added to the proxy injector, we can decouple the tracing tests from the viz and jaeger extensions. This creates a new set of top-level tests for tracing and moves the existing one from the viz integration tests, with a few modifications now that it doesn't have to install the extensions. Signed-off-by: Scott Fleener <[email protected]>
sfleen
force-pushed
the
sfleen/tracing-tests
branch
from
95b82e8 to
fba164f
Compare
adleong
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the proxy has tracing configuration added to the proxy injector, we can decouple the tracing tests from the viz and jaeger extensions.
This creates a new set of top-level tests for tracing and moves the existing one from the viz integration tests, with a few modifications now that it doesn't have to install the extensions.