-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(jaeger)!: Remove linkerd-jaeger
extension
#14558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This clarifies the tracing documentation that the trace collector must be meshed, along with the specifics of how the service account name for the collector should be set. Signed-off-by: Scott Fleener <[email protected]>
This separates out the service account namespace from the name to make it clearer how to set the correct service account for the trace collector. Signed-off-by: Scott Fleener <[email protected]>
…lector mesh identity Signed-off-by: Scott Fleener <[email protected]>
The current control plane tracing relies on the linkerd-jaeger extension, and does not work when using the native tracing configuration. This removes the previous configs, and adds new control plane tracing config that mirrors the existing proxy tracing configs. The previous configuration was meant entirely for internal testing purposes, and shouldn't be subject to any breaking change guarantees. Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
linkerd-jaeger
extension
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
…e fields Signed-off-by: Scott Fleener <[email protected]>
# Conflicts: # cli/cmd/install_test.go # pkg/charts/linkerd2/values.go
linkerd-jaeger
extensionlinkerd-jaeger
extension
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
# Conflicts: # cli/cmd/install_test.go # pkg/charts/linkerd2/values.go # pkg/charts/linkerd2/values_test.go
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
# Conflicts: # cli/cmd/install_test.go # pkg/charts/linkerd2/values.go
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
Signed-off-by: Scott Fleener <[email protected]>
# Conflicts: # cli/cmd/install_test.go # pkg/charts/linkerd2/values.go # pkg/charts/linkerd2/values_test.go
# Conflicts: # cli/cmd/install_test.go # pkg/charts/linkerd2/values.go # pkg/charts/linkerd2/values_test.go
olix0r
approved these changes
Oct 1, 2025
adleong
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
linkerd-jaeger
extension. Existing published versions/helm charts will still be available for use, but we will no longer publish new versions.This extension has been effectively unmaintained for some time, and has bitrotted significantly. It used a very old version of both jaeger and the OpenTelemetry collector. Additionally, all of the injector functionality has been integrated into the control plane helm chart.
A future PR will add migration documentation, with an example for installing POC tracing infrastructure on a cluster as a direct migration.