feat: Add labels for root parent object #14578
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,7 @@ import ( | |
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/labels" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/client-go/informers" | ||
| "k8s.io/client-go/metadata" | ||
| "k8s.io/client-go/metadata/metadatainformer" | ||
|
|
@@ -213,14 +214,14 @@ func (api *MetadataAPI) GetByNamespaceFiltered( | |
| // Kubernetes singular resource type (e.g. deployment, daemonset, job, etc.). | ||
| // If retry is true, when the shared informer cache doesn't return anything we | ||
| // try again with a direct Kubernetes API call. | ||
| func (api *MetadataAPI) GetOwnerKindAndName(ctx context.Context, pod *corev1.Pod, retry bool) (string, string) { | ||
| ownerRefs := pod.GetOwnerReferences() | ||
| if len(ownerRefs) == 0 { | ||
| // pod without a parent | ||
| return "pod", pod.Name | ||
| } else if len(ownerRefs) > 1 { | ||
| log.Debugf("unexpected owner reference count (%d): %+v", len(ownerRefs), ownerRefs) | ||
| return "pod", pod.Name | ||
| } | ||
|
|
||
| parent := ownerRefs[0] | ||
|
|
@@ -258,18 +259,69 @@ func (api *MetadataAPI) GetOwnerKindAndName(ctx context.Context, pod *corev1.Pod | |
| } | ||
|
|
||
| if rsObj == nil || !isValidRSParent(rsObj) { | ||
| return strings.ToLower(parent.Kind), parent.Name | ||
| } | ||
| parentObj = rsObj | ||
| default: | ||
| return strings.ToLower(parent.Kind), parent.Name | ||
| } | ||
|
|
||
| if err == nil && len(parentObj.GetOwnerReferences()) == 1 { | ||
| grandParent := parentObj.GetOwnerReferences()[0] | ||
| return strings.ToLower(grandParent.Kind), grandParent.Name | ||
| } | ||
| return strings.ToLower(parent.Kind), parent.Name | ||
| } | ||
|
|
||
| // GetRootOwnerKindAndName returns the resource's owner's type and metadata, using owner | ||
| // references from the Kubernetes API. Parent refs are recursively traversed to find the | ||
| // root parent resource, at least as far as the controller has permissions to query. | ||
| // This will attempt to lookup resources through the shared informer cache where possible, | ||
| // but may fall back to direct Kubernetes API calls where necessary. | ||
| func (api *MetadataAPI) GetRootOwnerKindAndName(ctx context.Context, tm *metav1.TypeMeta, om *metav1.ObjectMeta) (*metav1.TypeMeta, *metav1.ObjectMeta) { | ||
| ownerRefs := om.OwnerReferences | ||
| if len(ownerRefs) == 0 { | ||
| // resource without a parent | ||
| log.Debugf("Found root owner ref (%s)", om) | ||
| return tm, om | ||
| } else if len(ownerRefs) > 1 { | ||
| log.Debugf("unexpected owner reference count (%d): %+v", len(ownerRefs), ownerRefs) | ||
| return tm, om | ||
| } | ||
|
|
||
| parentRef := ownerRefs[0] | ||
| // The set of resources that we look up in the indexer are fairly niche. They all must be able to: | ||
| // - be a parent of another resource, usually a Pod | ||
| // - have a parent resource themselves | ||
| // Currently, this is limited to Jobs (parented by CronJobs) and ReplicaSets (parented by | ||
| // Deployments, StatefulSets, argo Rollouts, etc.). This list may change in the future, but | ||
| // is sufficient for now. | ||
| switch parentRef.Kind { | ||
| case "Job": | ||
| parent, err := api.getByNamespace(Job, om.Namespace, parentRef.Name) | ||
| if err == nil { | ||
| return api.GetRootOwnerKindAndName(ctx, &parent.TypeMeta, &parent.ObjectMeta) | ||
| } | ||
| log.Warnf("failed to retrieve job from indexer %s/%s: %s", om.Namespace, parentRef.Name, err) | ||
| case "ReplicaSet": | ||
| parent, err := api.getByNamespace(RS, om.Namespace, parentRef.Name) | ||
| if err == nil { | ||
| return api.GetRootOwnerKindAndName(ctx, &parent.TypeMeta, &parent.ObjectMeta) | ||
| } | ||
| log.Warnf("failed to retrieve replicaset from indexer %s/%s: %s", om.Namespace, parentRef.Name, err) | ||
| } | ||
|
|
||
| resource := schema.FromAPIVersionAndKind(parentRef.APIVersion, parentRef.Kind). | ||
| GroupVersion(). | ||
| WithResource(parentRef.Kind) | ||
|
||
| parent, err := api.client.Resource(resource). | ||
| Namespace(om.Namespace). | ||
| Get(ctx, parentRef.Name, metav1.GetOptions{}) | ||
| if err != nil { | ||
| log.Warnf("failed to retrieve resource from direct API call %s/%s/%s: %s", schema.FromAPIVersionAndKind(parentRef.APIVersion, parentRef.Kind), om.Namespace, parentRef.Name, err) | ||
| return &metav1.TypeMeta{Kind: parentRef.Kind, APIVersion: parentRef.APIVersion}, &metav1.ObjectMeta{Name: parentRef.Name, Namespace: om.Namespace} | ||
| } | ||
| return api.GetRootOwnerKindAndName(ctx, &parent.TypeMeta, &parent.ObjectMeta) | ||
| } | ||
|
|
||
| func (api *MetadataAPI) addInformer(res APIResource, informerLabels prometheus.Labels) error { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts about replacing this with the new function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. I can put out a follow-up for this, since the current implementation doesn't support controlling retry logic.