Sorted properties from custom context #57
Conversation
Fixed typo in ConnectionDialog label
|
|
|
It's not column ordinal as it doesn't make a call to the database when generating the tree. From some test I am doing it looks to be in the order that the properties are in the source (which is logical) but I doesn't always seem to be this way as the context I was originally trying this with has the properties in alphabetic order. I don't have this to had today but I'll do some more tests to confrm this and that the fix actually works. Leave it with me. |
|
Ah, you are right. Here we load columns using reflection. Usually it is ordered by declaration order in source code due to implementation, but as it documented here it is not always true :) |
| @@ -54,6 +54,7 @@ public IEnumerable<ExplorerItem> GetSchema() | |||
| .Where(p => | |||
| p.GetCustomAttributeLike<ObsoleteAttribute>() == null && | |||
| p.PropertyType.MaybeChildOf(typeof(IQueryable<>))) | |||
| .OrderBy(p => p.Name) | |||
There was a problem hiding this comment.
I suggest to sort by ColumnAttribute.Order for columns with HasOrder and by name for rest
There was a problem hiding this comment.
The original change will sort the tables. I'm still trying to sort the columns but I will honor the ColumnAttribute if the order is specified.
There was a problem hiding this comment.
not sure of helpful, but here we apply similar sorting for columns in create table based on Order: https://github.com/linq2db/linq2db/blob/master/Source/LinqToDB/SqlProvider/BasicSqlBuilder.cs#L1111
There was a problem hiding this comment.
Tables and columns shold now sort by name honouring column attribute order if applicable
Sorted properties from custom context
Fixed typo in ConnectionDialog label
Fixes #56