Skip to content

Fix remove_hosts() function #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main_base
Choose a base branch
from
Open

Fix remove_hosts() function #21

wants to merge 1 commit into from

Conversation

kdevops-kpd[bot]
Copy link

@kdevops-kpd kdevops-kpd bot commented Nov 11, 2024

Pull request for series with
subject: Fix remove_hosts() function
version: 1
url: https://patchwork.kernel.org/project/kdevops/list/?series=908579

@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 11, 2024

Upstream branch: 5d9af77
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 12, 2024

Upstream branch: 45dd47e
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 1b0b691 to a71a634 Compare November 12, 2024 22:58
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 12, 2024

Upstream branch: 11f72ce
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from a71a634 to 8b6158a Compare November 12, 2024 23:11
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 12, 2024

Upstream branch: 39aeba4
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 8b6158a to 52c19ba Compare November 12, 2024 23:50
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 18, 2024

Upstream branch: 683610d
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 52c19ba to c4b75ec Compare November 18, 2024 21:48
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 23, 2024

Upstream branch: 01b0bdd
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from c4b75ec to 7925d0f Compare November 23, 2024 00:39
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 23, 2024

Upstream branch: b9e7570
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 7925d0f to e5b413f Compare November 23, 2024 02:54
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 26, 2024

Upstream branch: 1046d42
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from e5b413f to 7d3a94d Compare November 26, 2024 19:27
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Nov 26, 2024

Upstream branch: ad7a161
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 7d3a94d to 3f0dbcc Compare November 26, 2024 22:52
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Jan 2, 2025

Upstream branch: 775d123
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Mar 21, 2025

Upstream branch: 0e172a8
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from c6581c4 to 1c59f33 Compare March 21, 2025 15:06
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 6, 2025

Upstream branch: 3521091
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 1c59f33 to 49fa0ba Compare April 6, 2025 23:28
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 21, 2025

Upstream branch: 23c9fca
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 49fa0ba to 953996f Compare April 21, 2025 16:45
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 21, 2025

Upstream branch: ef5f294
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 953996f to ab39fa7 Compare April 21, 2025 23:18
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 22, 2025

Upstream branch: 7ce773b
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from ab39fa7 to 9876f4f Compare April 22, 2025 07:19
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 22, 2025

Upstream branch: 1199224
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 9876f4f to 2784f7c Compare April 22, 2025 09:24
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 22, 2025

Upstream branch: 4a0beb6
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 2784f7c to acc0e45 Compare April 22, 2025 10:00
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 22, 2025

Upstream branch: 292c2a5
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from acc0e45 to 485674c Compare April 22, 2025 10:25
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 24, 2025

Upstream branch: 76b19c2
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 485674c to 29ce530 Compare April 24, 2025 17:24
@kdevops-kpd
Copy link
Author

kdevops-kpd bot commented Apr 24, 2025

Upstream branch: 370657c
series: https://patchwork.kernel.org/project/kdevops/list/?series=908579
version: 1

@chucklever
Fix remove_hosts() function
d505607 
Commit 3b6fbaaaf1df ("update_ssh_config.py: add IP address on Host
line") added an IP address at the end of each Host line. This extra
field breaks the simple host entry matching logic in the
remove_hosts() function, making "--remove" a no-op.

If the ssh_config entries are not removed, the config file grows
without bounds. If new hostnames are added that have the same name
as existing entries, ssh to those hosts fails, which makes certain
Ansible tasks hang for a bit and then fail.

Fixes: 3b6fbaaaf1df ("update_ssh_config.py: add IP address on Host line")
Signed-off-by: Chuck Lever <[email protected]>
@kdevops-kpd kdevops-kpd bot force-pushed the series/908579=>main branch from 29ce530 to d505607 Compare April 24, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
main new V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chucklever