Skip to content

fix(xcontext): api_method should be a Field #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

mahmednabil109
Copy link
Contributor

make "api_method" a field in order not to miss the metric counters

xaionaro
xaionaro previously approved these changes Jul 7, 2022
@mimir-d
Copy link
Member

mimir-d commented Jul 7, 2022

i'll add some missing context here. This metric tag is temporarily disabled until a future rewrite of the whole metrics/tracing system. It's currently splitting the running_jobs metric in multiple pieces, hence the disable.

@mahmednabil109
Copy link
Contributor Author

resolved by this issue
docker-library/mysql#881 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #95 (7c09970) into main (a37c87a) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

❗ Current head 7c09970 differs from pull request most recent head 050d744. Consider uploading reports for the commit 050d744 to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   67.07%   67.01%   -0.06%     
==========================================
  Files         157      157              
  Lines        9642     9642              
==========================================
- Hits         6467     6462       -5     
- Misses       2496     2498       +2     
- Partials      679      682       +3     
Flag Coverage Δ
e2e 52.05% <60.00%> (-0.09%) ⬇️
integration 58.75% <80.00%> (+0.02%) ⬆️
unittests 48.94% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/api.go 71.03% <80.00%> (ø)
pkg/remote/sync.go 94.11% <0.00%> (-5.89%) ⬇️
pkg/runner/step_runner.go 87.40% <0.00%> (-0.77%) ⬇️
pkg/xcontext/context.go 66.82% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37c87a...050d744. Read the comment docs.

@mimir-d mimir-d merged commit 6e63f27 into linuxboot:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants