Skip to content

feat: add soft delete mixin#337

Draft
Kumzy wants to merge 2 commits into
litestar-org:mainfrom
Kumzy:softdelete
Draft

feat: add soft delete mixin#337
Kumzy wants to merge 2 commits into
litestar-org:mainfrom
Kumzy:softdelete

Conversation

@Kumzy

@Kumzy Kumzy commented Jan 11, 2025

Copy link
Copy Markdown
Member

Creating a mixin for soft delete.

Do you think we need more in the Mixin?

Missing tests + repository changes + documentation

@Kumzy Kumzy changed the title feat: add softdelete mixin feat: add soft delete mixin Jan 11, 2025
@Kumzy Kumzy changed the title feat: add soft delete mixin feat: add soft delete mixin Jan 11, 2025
@cofin cofin added the 2.x Advanced Alchemy V2 label Oct 19, 2025
@codecov-commenter

codecov-commenter commented Oct 26, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.32%. Comparing base (c5ea0c9) to head (868b1bb).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
advanced_alchemy/mixins/softdelete.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   82.43%   82.32%   -0.11%     
==========================================
  Files         105      106       +1     
  Lines        9039     9053      +14     
  Branches     1219     1219              
==========================================
+ Hits         7451     7453       +2     
- Misses       1262     1274      +12     
  Partials      326      326              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hasansezertasan

Copy link
Copy Markdown
Member

I love the idea, soft deletes rules!

That said, I'd love AA to have deeper support for it. Such as deletion-aware repository/service methods like get_one, list, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants