Skip to content

feat: check for existing request_class config#5

Merged
cofin merged 2 commits into
mainfrom
branch_check
Oct 23, 2024
Merged

feat: check for existing request_class config#5
cofin merged 2 commits into
mainfrom
branch_check

Conversation

@cofin

@cofin cofin commented Oct 23, 2024

Copy link
Copy Markdown
Member

Description

Closes

Summary by Sourcery

Introduce concurrency control in the CI workflow and enhance the plugin to check for an existing request_class configuration before setting it.

New Features:

  • Add concurrency control to GitHub Actions CI workflow to cancel in-progress runs for the same branch.

Enhancements:

  • Modify the plugin to check for an existing request_class configuration before setting it to HTMXRequest.

CI:

  • Introduce concurrency control in the CI workflow to manage simultaneous runs on the same branch.

@sourcery-ai

sourcery-ai Bot commented Oct 23, 2024

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

This pull request introduces two main changes: it adds concurrency control to the CI workflow and modifies the HTMX plugin to check for an existing request_class configuration before setting it.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add concurrency control to CI workflow
  • Introduce a concurrency group named 'test-${{ github.head_ref }}'
  • Enable cancellation of in-progress workflows
.github/workflows/ci.yml
Modify HTMX plugin to check for existing request_class configuration
  • Add a conditional check before setting app_config.request_class
  • Only set app_config.request_class to HTMXRequest if it's currently None
litestar_htmx/plugin.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@cofin cofin changed the title feat: check for existing request_class config feat: check for existing request_class config Oct 23, 2024
@cofin
cofin merged commit 1f6a038 into main Oct 23, 2024
@cofin
cofin deleted the branch_check branch October 23, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant