Repository navigation
fix: keep the last publisher transceiver of each kind - #2284
Merged
Merged
Conversation
After a stop of all media transceivers, some browsers give the next transceiver new header extension ids. The server keeps the first ids of the connection, and the browser rejects its answer. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 5078e70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
marked this pull request as ready for review
November 17, 2026 09:00
xianshijing-lk
approved these changes
Nov 18, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #2282, a republish of camera and microphone still fails in Safari 26.
setRemoteDescriptionrejects the answer withFailed to set recv parameters for m-section with mid='3'.setE2EEEnabled(false)takes this path, because it republishes all tracks. Chrome and Firefox do not fail.The cause is a change of header extension ids. The data channel section keeps the transport, so the guard of #2282 lets the client stop both transceivers. These browsers then give the next transceivers new ids:
sdes:midmoves from 9 to 4, andtransport-wide-ccfrom 4 to 3. The server keeps one id table per connection and answers with the first ids. Id 4 then means two extensions in one section. Chrome keeps the first ids for the new transceivers.Change
PCTransport.stopTransceiverskeeps the last live transceiver of each kind, audio and video. A live section keeps its ids, as before #2249. The publisher connection holds at most one inactive audio transceiver and one inactive video transceiver.This rule replaces the rule of #2282. One live transceiver also keeps the transport, so the data channel count is gone.
🤖 Generated with Claude Code