Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/room/PCTransportManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@ export class PCTransportManager {
};

const onAnswered = (offerId: number) => {
if (offerId > checkpoint) {
// offerId is 0 by default when connecting to older server versions
if (offerId === 0 || offerId > checkpoint) {
Comment on lines +293 to +294

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Premature completion of queued legacy negotiations

On legacy servers, onAnswered resolves a new publish request when an older, pending offer receives its unnumbered answer. applyRemoteDescription emits OfferAnswered before sending the queued negotiation containing the new track. Publishing returns early and clears its timeout before the required answer arrives.

Learn more

A publisher offer can already be pending when another track needs negotiation. In that case, createAndSendOffer queues a follow-up using renegotiate. When the older answer arrives, applyRemoteDescription emits OfferAnswered before starting that follow-up. Accepting every zero-ID answer resolves callers whose changes were absent from the answered offer. The caller then clears its deadline, so a missing follow-up answer no longer triggers that caller's negotiation timeout. publish can finish creating and announcing the publication before the follow-up succeeds.

Example: Offer 5 is awaiting its answer when Alice adds a camera track and requests negotiation. The legacy server answers offer 5 with ID 0. The camera publish request resolves, although only the subsequent offer 6 includes the camera.

Recommended fix: Associate unnumbered answers with the outstanding local offer generation and preserve the checkpoint comparison. Capture that generation before applying the answer or starting queued renegotiation. Add regression coverage for a zero-ID answer to an offer at the checkpoint, followed by the zero-ID answer to the required follow-up offer.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

cleanup();
resolve();
}
Expand Down
Loading