Repository navigation
fix: skip offer matching when connecting to old server versions #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukasIO
wants to merge
1
commit into
main
Choose a base branch
from
lukas/fix-old-server-compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Premature completion of queued legacy negotiations
On legacy servers,
onAnsweredresolves a new publish request when an older, pending offer receives its unnumbered answer.applyRemoteDescriptionemitsOfferAnsweredbefore sending the queued negotiation containing the new track. Publishing returns early and clears its timeout before the required answer arrives.Learn more
A publisher offer can already be pending when another track needs negotiation. In that case,
createAndSendOfferqueues a follow-up usingrenegotiate. When the older answer arrives,applyRemoteDescriptionemitsOfferAnsweredbefore starting that follow-up. Accepting every zero-ID answer resolves callers whose changes were absent from the answered offer. The caller then clears its deadline, so a missing follow-up answer no longer triggers that caller's negotiation timeout.publishcan finish creating and announcing the publication before the follow-up succeeds.Example: Offer 5 is awaiting its answer when Alice adds a camera track and requests negotiation. The legacy server answers offer 5 with ID 0. The camera publish request resolves, although only the subsequent offer 6 includes the camera.
Recommended fix: Associate unnumbered answers with the outstanding local offer generation and preserve the checkpoint comparison. Capture that generation before applying the answer or starting queued renegotiation. Add regression coverage for a zero-ID answer to an offer at the checkpoint, followed by the zero-ID answer to the required follow-up offer.
Was this helpful? React with 👍 or 👎 to provide feedback.