Skip to content

add other api services, token verifier & webhooks #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 14, 2023
Merged

add other api services, token verifier & webhooks #98

merged 15 commits into from
Nov 14, 2023

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Nov 14, 2023 •
edited
Loading 

api = api.LivekitAPI("http://theo.livekit.cloud")
api.room.CreateRoom(...)
api.ingress.CreateIngress(...)

@theomonnom theomonnom requested a review from davidzhao November 14, 2023 01:21
davidzhao
davidzhao reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this completes things quite nicely.

@theomonnom theomonnom changed the title add other api services add other api services, token verifier & webhooks Nov 14, 2023
@theomonnom theomonnom requested a review from davidzhao November 14, 2023 05:52
davidzhao
davidzhao approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Perhaps in a separate PR, could you also update README as well?

@theomonnom theomonnom merged commit ce81435 into main Nov 14, 2023
@theomonnom theomonnom deleted the theo/api-refactor branch November 14, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @davidzhao