feat: add eos events #184
Merged
feat: add eos events #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
approved these changes
Sep 8, 2023
| uint64 stream_handle = 1; | ||
| oneof message { | ||
| AudioFrameReceived frame_received = 2; | ||
| AudioStreamEOS eos = 3; |
There was a problem hiding this comment.
this works, but you can also consider to use a bool as a marker. with oneof messages, the position/field name is sufficient to mark special types.
There was a problem hiding this comment.
TIL, I think it's ok for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to make sure we're not leaking any memory by ignoring some ffi events while closing too early