Repository navigation
Fail a publish whose source changed since its tag - #105
Merged
Merged
Conversation
Closes #104 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This PR bumps
|
lukasIO
added a commit
to livekit/node-sdks
that referenced
this pull request
Nov 17, 2026
The next verwalter release checks in publish that each package matches its tag (livekit/verwalter#105). Until then, a run by hand sets ref to the tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
ladvoc
approved these changes
Nov 19, 2026
lukasIO
added a commit
to livekit/node-sdks
that referenced
this pull request
Nov 19, 2026
…784) * Release with verwalter instead of changesets/action Add verwalter.toml and the four verwalter workflows (release PR, release, pre-release, changeset check). Remove the changesets/action job from CI, .changeset/config.json, the ci:publish script and the changesets devDependencies. Pending .changeset/*.md files carry over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address review: rc releases, stale scripts, docs failures Run the release workflow for verwalter PRs on any base branch, so an rc PR from another branch is tagged and published. Remove the server SDK's changeset and ci:publish scripts. Let a failed docs build or upload fail the publish job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Upload the server SDK docs only for a stable version An rc release must not replace the docs of the current stable release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release: docs in their own job, one publish at a time A docs failure no longer turns the publish job red after npm has the version. A publish job waits for a running one instead of publishing the same version twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release: guard source on runs by hand, narrow docs, queue publishes - Add a ref input for runs by hand. Before the build, fail when a package to publish differs from its release tag. - Upload the server SDK docs only when this run released a final server SDK version from main. - Keep every waiting publish run with queue: max. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release: drop the source guard step The next verwalter release checks in publish that each package matches its tag (livekit/verwalter#105). Until then, a run by hand sets ref to the tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release: verwalter v0.31.0, verify the end state v0.31.0 checks in publish that each package matches its tag, so the note about v0.30.0 goes. A verify job runs status --check after the publish, as in the upstream example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release: build before the tag A build job runs first and uploads the build output. A build that fails now stops the run before release creates any tag. publish and docs use that output instead of building after the tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
publishchecks only that the tag of a package's version exists. A run by hand (workflow_dispatch) withoutrefchecks out the branch head. If a later commit changed the package but not its version,publishuploads the newer source under the tagged version. livekit/node-sdks#784 works around this with agit diffstep in its workflow. Closes #104.Change
publishnow compares the files of each package at its tag with HEAD (changed_since_tag). It does this before the publish command runs. If HEAD changed one, the command does not run. The package isfailed, with the reasonHEAD changed the source since <tag>: publish from ref=<tag>. Its dependents are blocked, as for any other failure.ownersrule as the changeset check (Count a file in a nested package for that package only #101). A change to a README at the root, or to another package, does not fail the check.[publish].workspace, one changed member stops the workspace command for every member (L381). The other members report which member changed.goproxypackages are not compared. The proxy serves the tag, not HEAD.publish --allow-changed-sourceturns the check off. There is no config key for it.publish --dry-runshows it before a real run.The spec has the check in
WorkflowPublishesInDependencyOrder.docs/features.md,docs/commands.mdand the "Pin the commit" rule indocs/release-workflows.mddescribe it.Verified
cargo fmt --all -- --check,cargo clippy --all-targets -- -D warningsandcargo testpass.publish_fails_a_package_whose_source_changed_since_its_tagtags three packages, then commits a change tolivekit-apiand to a root README. It asserts thatlivekit-apifails withref=livekit-api-v0.4.3and the other two publish. It also covers the registry skip, the flag and the workspace command. Withchanged_since_tagforced to returnfalse, the test fails.allium check specs/versioning.alliumgives the same diagnostics as onmain.The test file had one
.err().expect()that the current clippy rejects. It is now.expect_err().🤖 Generated with Claude Code