Skip to content

Rules: lessons from the client-sdk-js and node-sdks reviews - #112

Merged
lukasIO merged 1 commit into
mainfrom
claude/verwalter-rules-review-lessons
Nov 19, 2026
Merged

lukasIO merged 1 commit into
mainfrom
claude/verwalter-rules-review-lessons

Conversation

@lukasIO

@lukasIO lukasIO commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

The reviews of livekit/client-sdk-js#2279 and livekit/node-sdks#784 found three weaknesses that docs/release-workflows.md does not cover. One of its rules gave advice that is wrong for npm.

Change

  • "One writer per release" recommended a concurrency group per tag. For npm, the publish jobs of two versions then overlap, and the older one can finish last and take latest. The rule now names one group per registry with queue: max for such a registry, and a new pattern shows it.
  • "Steps after the publish get their own job" gets a check for a step that writes to one shared place, such as a docs site with one version: the package, the prerelease field and the main line, read from the fields of the handoff.
  • "One run owns one release" says that the trigger must cover every branch that can release.
  • The release-hardening skill has one new weakness row for each of the three.

Verified

The YAML patterns in the document parse. Nothing was run.

🤖 Generated with Claude Code

One publish at a time for a registry with a moving pointer, checks before
a step that writes to one shared place, and a trigger that covers every
branch that can release.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@lukasIO lukasIO self-assigned this Nov 18, 2026
@lukasIO
lukasIO marked this pull request as ready for review November 18, 2026 10:24
@lukasIO
lukasIO requested a review from ladvoc as a code owner November 18, 2026 10:24
@lukasIO
lukasIO merged commit 0844552 into main Nov 19, 2026
4 checks passed
@lukasIO
lukasIO deleted the claude/verwalter-rules-review-lessons branch November 19, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants