Repository navigation
Rules: lessons from the client-sdk-js and node-sdks reviews - #112
Merged
Merged
Conversation
One publish at a time for a registry with a moving pointer, checks before a step that writes to one shared place, and a trigger that covers every branch that can release. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
ladvoc
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reviews of livekit/client-sdk-js#2279 and livekit/node-sdks#784 found three weaknesses that
docs/release-workflows.mddoes not cover. One of its rules gave advice that is wrong for npm.Change
latest. The rule now names one group per registry withqueue: maxfor such a registry, and a new pattern shows it.prereleasefield and the main line, read from the fields of the handoff.release-hardeningskill has one new weakness row for each of the three.Verified
The YAML patterns in the document parse. Nothing was run.
🤖 Generated with Claude Code