Skip to content

Conversation

ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Add data url to trickle server to enable sending data up from ai-runner inference (e.g. transcriptions)

Also adds a SSE endpoint to gateway to be able to get the data for the stream. If preferred, can move the SSE endpoint to separate URL. Just no easy way to test the data_url without it so included it here.

Depends on livepeer/ai-runner#710

Specific updates (required)

  • add data_url to Orchestrator trickle server
  • add SSE endpoint as simple way to get data from a stream

How did you test each of these updates (required)

Built and ran full stack locally using: https://github.com/ad-astra-video/livepeer-app-pipelines/tree/main/comfystream

Does this pull request close any open issues?

Checklist:

@ad-astra-video ad-astra-video requested a review from j0sh July 28, 2025 21:55
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jul 28, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 2.02020% with 194 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.82047%. Comparing base (a50ac9f) to head (0dc72c4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 108 Missing ⚠️
server/ai_mediaserver.go 4.76190% 79 Missing and 1 partial ⚠️
server/ai_http.go 0.00000% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3689         +/-   ##
===================================================
- Coverage   31.94567%   31.82047%   -0.12520%     
===================================================
  Files            156         156                 
  Lines          47418       47614        +196     
===================================================
+ Hits           15148       15151          +3     
- Misses         31376       31568        +192     
- Partials         894         895          +1     
Files with missing lines Coverage Δ
ai/worker/runner.gen.go 7.23104% <ø> (ø)
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_http.go 9.58084% <0.00000%> (-0.08683%) ⬇️
server/ai_mediaserver.go 4.68750% <4.76190%> (+0.01023%) ⬆️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50ac9f...0dc72c4. Read the comment docs.

Files with missing lines Coverage Δ
ai/worker/runner.gen.go 7.23104% <ø> (ø)
core/livepeernode.go 60.22099% <ø> (ø)
server/ai_http.go 9.58084% <0.00000%> (-0.08683%) ⬇️
server/ai_mediaserver.go 4.68750% <4.76190%> (+0.01023%) ⬆️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants