docker: Fix stall when container stopped during creation

[victorges]

What does this pull request do? Explain your changes. (required)
This pull request introduces an early-exit mechanism during Docker container startup. It prevents the orchestrator from indefinitely waiting for a runner container to become available if it is killed or exits immediately after being launched, allowing for faster detection of failures and subsequent recovery/relaunch attempts.

Specific updates (required)

• ai/worker/docker.go: Modified dockerWaitUntilRunning to detect and return an error immediately if the container enters a terminal state (e.g., exited, dead, removing) or fails with a non-zero exit code or error without restarting.
• ai/worker/docker_test.go: Added new unit tests to validate the fail-fast behavior for containers that are exited, dead, or created with a non-zero exit code.

How did you test each of these updates (required)
New unit tests were added to ai/worker/docker_test.go to specifically cover the fail-fast scenarios. These tests mock the Docker client to simulate container inspections returning exited, dead, or created with a non-zero exit code. The tests assert that dockerWaitUntilRunning correctly returns an error in these situations, preventing an indefinite wait. All tests in ai/worker were run locally and passed.

Does this pull request close any open issues?

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

---

 

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[codecov]

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.70967%. Comparing base (1bc682a) to head (df1704f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
ai/worker/docker.go	76.92308%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #3769         +/-   ##
===================================================
+ Coverage   31.68993%   31.70967%   +0.01974%     
===================================================
  Files            158         158                 
  Lines          47564       47588         +24     
===================================================
+ Hits           15073       15090         +17     
- Misses         31603       31609          +6     
- Partials         888         889          +1     

Files with missing lines	Coverage Δ
ai/worker/docker.go	69.68174% <76.92308%> (+0.53096%)	⬆️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dff847...df1704f. Read the comment docs.

Files with missing lines	Coverage Δ
ai/worker/docker.go	69.68174% <76.92308%> (+0.53096%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.