fix cargo-mutagen usage as cargo subcommand #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llogiq
reviewed
Mar 24, 2020
mutagen-runner/src/main.rs
Outdated
| let mutagen_start = Instant::now(); | ||
|
|
||
| let opt = Options::from_args(); | ||
| // drop mutagen arg in cargo-subcommand mode |
Owner
There was a problem hiding this comment.
What if there is another "mutagen" arg?
Contributor
Author
There was a problem hiding this comment.
I've added code to try and detect when we're in "cargo subcommand" mode. From the wiki, cargo sets the CARGO env var to its path on the system. This is assuming that the user hasn't set the CARGO env var himself for some reason :/
cargo passes all args to the subcommand program, which means our binary
will receive "mutagen" as first argument when invoked like this:
$ cargo mutagen
This produced an error, because structopt doesn't expect a "mutagen"
argument at all:
error: Found argument 'mutagen' which wasn't expected, or isn't
valid in this context
USAGE:
cargo-mutagen [FLAGS] [OPTIONS]
For more information try --help
alarsyo
force-pushed
the
cargo-mutagen-subcommand-fix
branch
from
5e23b68 to
87abab2
Compare
Owner
|
Looks good to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo passes all args to the subcommand program, which means our binary will receive "mutagen" as first argument when invoked like this:
This produced an error, because structopt doesn't expect a "mutagen" argument at all:
For a similar problem, see rust-lang/rustfmt#3569.
This is how they handle it: https://github.com/rust-lang/rustfmt/blob/9124dd88d6ef14d0ae77dc52ff5e9598f24a75a0/rustfmt-core/rustfmt-bin/src/cargo-fmt/main.rs#L77
I've opted for a simpler solution because I don't think
mutagencould be one of the arguments forcargo-mutagencurrently (naming an eventual featuremutagendoesn't seem right). If you think this might be a problem later on, we can find a better fix :)