[CIR][ABI][AArch64][Lowering] support for passing struct types > 128 bits #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
@bzcheeseman: @gitoleg has also been working on aarch64 in case you want to follow / also provide insights. |
If you can do that it would be great, will make everyone's life easier when trying to reach completeness |
|
Actually |
bcardosolopes
approved these changes
Nov 6, 2024
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
…bits (#1068) This PR adds a partial support for so-called indirect function arguments for struct types with size > 128 bits for aarch64. #### Couple words about the implementation The hard part is that it's not one-to-one copy from the original codegen, but the code is inspired by it of course. In the original codegen there is no much job is done for the indirect arguments inside the loop in the `EmitFunctionProlog`, and additional alloca is added in the end, in the call for `EmitParamDecl` function. In our case, for the indirect argument (which is a pointer) we replace the original alloca with a new one, and store the pointer in there. And replace all the uses of the old alloca with the load from the new one, i.e. in both cases users works with the pointer to a structure. Also, I added several missed features in the `constructAttributeList` for indirect arguments, but didn't preserve the original code structure, so let me know if I need to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a partial support for so-called indirect function arguments for struct types with size > 128 bits for aarch64.
Couple words about the implementation
The hard part is that it's not one-to-one copy from the original codegen, but the code is inspired by it of course.
In the original codegen there is no much job is done for the indirect arguments inside the loop in the
EmitFunctionProlog, and additional alloca is added in the end, in the call forEmitParamDeclfunction.In our case, for the indirect argument (which is a pointer) we replace the original alloca with a new one, and store the pointer in there. And replace all the uses of the old alloca with the load from the new one, i.e. in both cases users works with the pointer to a structure.
Also, I added several missed features in the
constructAttributeListfor indirect arguments, but didn't preserve the original code structure, so let me know if I need to do it.