This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[CIR][CodeGen][Builtin] Implement builtin cosh, sinh and tanh#2112
Open
bruteforceboy wants to merge 1 commit intollvm:mainfrom
Open
[CIR][CodeGen][Builtin] Implement builtin cosh, sinh and tanh#2112bruteforceboy wants to merge 1 commit intollvm:mainfrom
bruteforceboy wants to merge 1 commit intollvm:mainfrom
Conversation
bruteforceboy
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Member
|
Hey @bruteforceboy, since this is a new PR, how about you do it directly upstream? Or create an issue to track what's missing so that can happen? https://discourse.llvm.org/t/clangir-transition-plans-for-the-clangir-incubator/89583 |
Contributor
Author
Sure, that sounds like a good idea! I'm glad to see the work is now going upstream. It seems there is an open PR (llvm/llvm-project#178093) that is doing some work related to this. Once it is complete, I will follow up with this PR. |
Member
|
@bruteforceboy thanks a bunch!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the code generation/lowering of the
cosh,sinhandtanhbuiltins + tests.