Skip to content

[CIR][NFC] Extend simple lowering to unary fp2int ops and binary fp2fp ops #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Sep 2, 2024

This PR makes simple lowering generate the result type lowering logic and make it suitable for unary fp2int operations and binary fp2fp operations.

…p ops

This patch makes simple lowering generate the result type lowering logic and
make it suitable for unary fp2int operations and binary fp2fp operations.
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is pretty cool

@bcardosolopes bcardosolopes merged commit 987f1e1 into llvm:main Sep 9, 2024
7 checks passed
@Lancern Lancern deleted the simple-lowering branch September 10, 2024 01:49
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
…p ops (llvm#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
…p ops (llvm#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
…p ops (llvm#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
…p ops (llvm#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
lanza pushed a commit that referenced this pull request Nov 5, 2024
…p ops (#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
lanza pushed a commit that referenced this pull request Mar 18, 2025
…p ops (#818)

This PR makes simple lowering generate the result type lowering logic
and make it suitable for unary fp2int operations and binary fp2fp
operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants