Skip to content

[CIR][CIRGen] Correct isSized predicate for vector type #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Sep 20, 2024

As title, if element type of vector type is sized, then the vector type should be deemed sized.
This would enable us generate code for neon without triggering assertion

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit ac8c6a5 into llvm:main Sep 20, 2024
7 checks passed
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
lanza pushed a commit that referenced this pull request Nov 5, 2024
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
lanza pushed a commit that referenced this pull request Mar 18, 2025
As title, if element type of vector type is sized, then the vector type
should be deemed sized.
This would enable us generate code for neon without triggering assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants