Skip to content

[libc] comparing with glibc for ctime, llvm implementation has an offset by 1 hour #109892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zimirza opened this issue Sep 25, 2024 · 0 comments
Open

[libc] comparing with glibc for ctime, llvm implementation has an offset by 1 hour #109892

zimirza opened this issue Sep 25, 2024 · 0 comments
Labels
libc

Comments

@zimirza
Copy link
Contributor

zimirza commented Sep 25, 2024

In main branch, not released version:

For t=0, glibc's ctime returns Thu Jan 1 01:00:00 1970\n, while llvm's ctime returns Thu Jan 1 00:00:00 1970\n.

For t=2147483647, glibc's ctime returns Tue Jan 19 04:14:07 2038\n, while llvm's ctime returns Tue Jan 19 03:14:07 2038\n.

It might be better to be consistent with glibc's implementation for compatibility reasons.
@github-actions github-actions bot added the libc label Sep 25, 2024
@nickdesaulniers nickdesaulniers mentioned this issue Sep 27, 2024
Merged
@zimirza zimirza mentioned this issue Sep 28, 2024
Open
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Sep 28, 2024
[libc] implement localtime
e69222a 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Sep 28, 2024
[libc] implement localtime
41b2238 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Dec 23, 2024
[libc] implement localtime
406379c 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Dec 26, 2024
[libc] implement localtime
a999454 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Dec 26, 2024
[libc] implement localtime
9bc3831 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Jan 1, 2025
@zimirza
[libc] implement localtime
15f14f6 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Jan 3, 2025
@zimirza
[libc] implement localtime
7e7a30a 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Jan 16, 2025
@zimirza
[libc] implement localtime
01f7fd0 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Jan 31, 2025
@zimirza
[libc] implement localtime
3fb9663 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Feb 12, 2025
@zimirza
[libc] implement localtime
7e7ca36 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
zimirza pushed a commit to zimirza/llvm-project that referenced this issue Apr 22, 2025
@zimirza
[libc] implement localtime
4a9ac7e 
This is an implementation of localtime.

Closes llvm#107597 and llvm#109892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zimirza