Skip to content

[HLSL][SPIRV] Bug in SPIRVGlobalRegistry::getOrCreateCompositeOrNull #113486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spall opened this issue Oct 23, 2024 · 1 comment · Fixed by #111082
Closed

[HLSL][SPIRV] Bug in SPIRVGlobalRegistry::getOrCreateCompositeOrNull #113486

spall opened this issue Oct 23, 2024 · 1 comment · Fixed by #111082
Assignees
@spall
Labels
backend:DirectX backend:SPIR-V clang:codegen IR generation bugs: mangling, exceptions, etc. clang:headers Headers provided by Clang, e.g. for intrinsics HLSL HLSL Language Support

Comments

@spall
Copy link
Contributor

spall commented Oct 23, 2024

Register type of register created by 'SPIRVGlobalRegistry::getOrCreateCompositeOrNull' is hardcoded to be 'iID' which is wrong. It should use the register class of the spirv type it is creating a register for.
@spall spall self-assigned this Oct 23, 2024
@spall spall mentioned this issue Oct 23, 2024
Merged
@EugeneZelenko EugeneZelenko added HLSL HLSL Language Support SPIR-V SPIR-V language support and removed new issue labels Oct 23, 2024
spall added a commit that referenced this issue Nov 6, 2024
@spall
[HLSL] implement elementwise firstbithigh hlsl builtin (#111082)
fb90733 
Implements elementwise firstbithigh hlsl builtin.
Implements firstbituhigh intrinsic for spirv and directx, which handles
unsigned integers
Implements firstbitshigh intrinsic for spirv and directx, which handles
signed integers.
Fixes #113486
Closes #99115
@github-project-automation github-project-automation bot moved this to Closed in HLSL Support Nov 6, 2024
@EugeneZelenko EugeneZelenko added clang:headers Headers provided by Clang, e.g. for intrinsics clang:codegen IR generation bugs: mangling, exceptions, etc. backend:DirectX backend:SPIR-V and removed SPIR-V SPIR-V language support labels Nov 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 6, 2024

@llvm/issue-subscribers-clang-codegen

Author: Sarah Spall (spall)

Register type of register created by 'SPIRVGlobalRegistry::getOrCreateCompositeOrNull' is hardcoded to be 'iID' which is wrong. It should use the register class of the spirv type it is creating a register for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spall spall

Labels
backend:DirectX backend:SPIR-V clang:codegen IR generation bugs: mangling, exceptions, etc. clang:headers Headers provided by Clang, e.g. for intrinsics HLSL HLSL Language Support
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] implement elementwise firstbithigh hlsl builtin spall/llvm-project
3 participants
@spall @EugeneZelenko @llvmbot