Change all cl::opt<> in .cpp files to static

[jurahul]

Most (if not all) of global variables for command line options need to be defined as static. This is currently not the case. To find candidates use:

git grep "cl::opt" *.cpp | grep -v static
git grep "cl::OptionCategory" *.cpp | grep -v static

[jurahul]

Can be a starter task for someone interested in contributing.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Rahul Joshi (jurahul)

Most (if not all) of global variables for command line options need to be defined as static. This is currently not the case. To find candidates use:

git grep "cl::opt" *.cpp | grep -v static
git grep "cl::OptionCategory" *.cpp | grep -v static

[chrisPyr]

Hi, I'm new here, I'm interested in taking on this issue, can I get assigned? Thx

[DanielAugusto191]

Also interested in it, let me know if I can help.

[chrisPyr]

@DanielAugusto191
hi, thanks for you kindness, I think I have done most part of the task.

I have created a branch in my forked project that I use for this issue, and you can see it in the PR link above.
Right now, I have tried my best to find all the candidates and modified them. After the changes, I have tried compiled with -DLLVM_ENABLE_PROJECTS=all. And I also tested with llvm unitest and regression test, both are passed.

So I think maybe you can help finding if I missed any candidate or getting anything wrong.