[llvm-strip] llvm-strip --strip-unneeded cannot would stop stripping if it encounters failure for one file

[trcrsired]

i do

llvm-strip --strip-unneeded *

under a directory. strip can ignore the errors and move on but llvm-strip cannot. How to fix it?

[llvmbot]

@llvm/issue-subscribers-tools-llvm-objcopy-strip

Author: cqwrteur (trcrsired)

i do ``` llvm-strip --strip-unneeded * ``` under a directory. strip can ignore the errors and move on but llvm-strip cannot. How to fix it?

[jh7370]

You'd need to call llvm-strip on each object, rather than on all objects in the directory, as llvm-strip doesn't provide an option to "keep going" on failure.

The loop at

llvm-project/llvm/tools/llvm-objcopy/llvm-objcopy.cpp

Line 250 in 3d5348b

for (ConfigManager &ConfigMgr : DriverConfig->CopyConfigs) {

is where the relevant logic is, I believe (llvm-strip shares the same code as llvm-objcopy for the most part). There is one ConfigMgr per input file, which is then passed to executeObjcopy. On failures, an Error is returned to the loop, which logs the error and then returns 1, rather than continuing the loop.

I think it would be fairly straightforward to change this behaviour to imitate GNU strip here. Simply don't bail out of the loop early, but make sure to record whether any failures have occurred and return after the loop with an exit code dependent on this. I'll add the good-first-issue label for that.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: cqwrteur (trcrsired)

i do ``` llvm-strip --strip-unneeded * ``` under a directory. strip can ignore the errors and move on but llvm-strip cannot. How to fix it?

[meltq]

I've begun working on this. Requesting for this to be assigned to me.