[flang][do concurrent] sequential implementation regressed to TODO when local_init are involved

[jeanPerier]

It was previously possible to compile miniWeather app with flang, but it just regressed to hitting the following TODO:

loc("miniWeather_mpi_do_concurrent.F90":324:40):  flang/lib/Optimizer/Transforms/SimplifyFIROperations.cpp:191: not yet implemented: localizers with `init` and `dealloc` regions are not handled yet.
LLVM ERROR: aborting

Reproducer (probably meaningless from a functional point of view):

  integer, parameter :: N = 10
  integer, target    :: a(N)
  integer            :: t(N)
  integer, pointer   :: p(:)

  a = 1
  p => a

  do concurrent (i=1:N) local(t) local_init(p)
     t(i) = p(i)
  enddo
end

Is it possible to avoid switching to the new implementation until all TODOs are implemented in SimplifyFIROperations?

[jeanPerier]

Looking at recent commits, I think this is because Do Concurrent new lowering was enabled by default here: 937be17

Maybe this should be reverted until all TODOs in SimplifyFIROperations.cpp are implemented.

[llvmbot]

@llvm/issue-subscribers-flang-ir

Author: None (jeanPerier)

It was previously possible to compile miniWeather app with flang, but it just regressed to hitting the following TODO:

loc("miniWeather_mpi_do_concurrent.F90":324:40):  flang/lib/Optimizer/Transforms/SimplifyFIROperations.cpp:191: not yet implemented: localizers with `init` and `dealloc` regions are not handled yet.
LLVM ERROR: aborting

Reproducer (probably meaningless from a functional point of view):

  integer, parameter :: N = 10
  integer, target    :: a(N)
  integer            :: t(N)
  integer, pointer   :: p(:)

  a = 1
  p => a

  do concurrent (i=1:N) local(t) local_init(p)
     t(i) = p(i)
  enddo
end

Is it possible to avoid switching to the new implementation until all TODOs are implemented in SimplifyFIROperations?

[ergawy]

Sorry about that. Revert PR: #143905. And I will take care of the todo.