Skip to content

Missed optimization in math expression: simplify calls std::pow functions #34941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zamazan4ik opened this issue Dec 10, 2017 · 3 comments
Closed
Labels
bugzilla Issues migrated from bugzilla llvm:instcombine

Comments

@zamazan4ik
Copy link

zamazan4ik commented Dec 10, 2017

Bugzilla Link 35593
Version trunk
OS All
Blocks #34959
CC @rotateright

Extended Description

clang(trunk) with '--std=c++17 -O3 -march=native -ffast-math' flags for this code:

#include <cmath>

double f(double a, double b, double c)
{
    return std::pow(a, b) * std::pow(a, c);
}

generates this assembly:

f(double, double, double): # @f(double, double, double)
  sub rsp, 24
  vmovsd qword ptr [rsp + 16], xmm2 # 8-byte Spill
  vmovsd qword ptr [rsp], xmm0 # 8-byte Spill
  call pow
  vmovsd qword ptr [rsp + 8], xmm0 # 8-byte Spill
  vmovsd xmm0, qword ptr [rsp] # 8-byte Reload
  vmovsd xmm1, qword ptr [rsp + 16] # 8-byte Reload
  call pow
  vmulsd xmm0, xmm0, qword ptr [rsp + 8] # 8-byte Folded Reload
  add rsp, 24
  ret

GCC (trunk) with '--std=c++17 -O3 -march=native -ffast-math' flags generates more optimal code:

f(double, double, double):
        vaddsd  xmm1, xmm1, xmm2
        jmp     __pow_finite
@zamazan4ik
Copy link
Author

@RKSimon
Copy link
Collaborator

RKSimon commented Nov 27, 2021

mentioned in issue #34959

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
@rotateright
Copy link
Contributor

This was fixed along with other pow folds shown in #34943.
This was:
7736c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla llvm:instcombine
Projects
None yet
Development

No branches or pull requests

4 participants