Skip to content

[clang-tidy] Options in --dump-config should be sorted #64153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PiotrZSL opened this issue Jul 27, 2023 · 2 comments
Closed

[clang-tidy] Options in --dump-config should be sorted #64153

PiotrZSL opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature

Comments

@PiotrZSL
Copy link
Member

Example:

--dump-config --checks="*"

--
Checks:          'clang-diagnostic-*,clang-analyzer-*,*'
WarningsAsErrors: ''
HeaderFileExtensions:
  - ''
  - h
  - hh
  - hpp
  - hxx
ImplementationFileExtensions:
  - c
  - cc
  - cpp
  - cxx
HeaderFilterRegex: ''
FormatStyle:     none
CheckOptions:
  readability-magic-numbers.IgnoredIntegerValues: '1;2;3;4;'
  misc-const-correctness.TransformValues: 'true'
  cppcoreguidelines-narrowing-conversions.IgnoreConversionFromTypes: ''
  bugprone-argument-comment.CommentFloatLiterals: '0'
  modernize-use-emplace.ContainersWithPush: '::std::stack;::std::queue;::std::priority_queue'
  misc-const-correctness.AnalyzeValues: 'true'
  hicpp-special-member-functions.AllowMissingMoveFunctionsWhenCopyIsDeleted: 'false'
  modernize-use-bool-literals.IgnoreMacros: 'true'
  google-readability-function-size.LineThreshold: '4294967295'
  portability-simd-intrinsics.Std: ''
  modernize-make-unique.IgnoreMacros: 'true'
  modernize-use-emplace.ContainersWithPushFront: '::std::forward_list;::std::list;::std::deque'
  cppcoreguidelines-pro-type-member-init.UseAssignment: 'false'
  misc-definitions-in-headers.HeaderFileExtensions: ';h;hh;hpp;hxx'
  cppcoreguidelines-narrowing-conversions.WarnOnEquivalentBitWidth: 'true'
  readability-uppercase-literal-suffix.IgnoreMacros: 'true'
  bugprone-dangling-handle.HandleClasses: 'std::basic_string_view;std::experimental::basic_string_view'
  readability-function-cognitive-complexity.DescribeBasicIncrements: 'true'
  llvm-else-after-return.WarnOnUnfixable: 'false'
  readability-container-data-pointer.IgnoredContainers: ''
  bugprone-exception-escape.IgnoredExceptions: ''
  google-build-namespaces.HeaderFileExtensions: ';h;hh;hpp;hxx'
  altera-single-work-item-barrier.AOCVersion: '1600'
  hicpp-use-noexcept.UseNoexceptFalse: 'true'
  hicpp-use-emplace.SmartPointers: '::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr'
  hicpp-use-override.FinalSpelling: final
  modernize-deprecated-headers.CheckHeaderFile: 'false'
  cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor: 'false'
  concurrency-mt-unsafe.FunctionSet: any
  bugprone-suspicious-missing-comma.RatioThreshold: '0.200000'
  cert-str34-c.DiagnoseSignedUnsignedCharComparisons: 'false'
  hicpp-braces-around-statements.ShortStatementLines: '0'
  misc-include-cleaner.IgnoreHeaders: ''
  modernize-loop-convert.MakeReverseRangeFunction: ''
  cppcoreguidelines-no-malloc.Allocations: '::malloc;::calloc'
  modernize-use-override.FinalSpelling: final
  cert-msc32-c.DisallowedSeedTypes: 'time_t,std::time_t'
  cppcoreguidelines-avoid-do-while.IgnoreMacros: 'false'
  bugprone-argument-comment.CommentStringLiterals: '0'
  modernize-use-equals-default.IgnoreMacros: 'true'
  modernize-make-shared.IgnoreDefaultInitialization: 'true'
  abseil-string-find-startswith.IncludeStyle: llvm
  readability-function-size.ParameterThreshold: '4294967295'

Config options are printed in random order, and it's hard to find needed options.
Options should be sorted by check name + option name.

@PiotrZSL PiotrZSL added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature clang-tidy labels Jul 27, 2023
@llvmbot
Copy link
Member

llvmbot commented Jul 27, 2023

@llvm/issue-subscribers-clang-tidy

@PiotrZSL PiotrZSL self-assigned this Jul 27, 2023
@PiotrZSL
Copy link
Member Author

@PiotrZSL PiotrZSL added the awaiting-review Has pending Phabricator review label Jul 27, 2023
@PiotrZSL PiotrZSL removed the awaiting-review Has pending Phabricator review label Jul 27, 2023
PiotrZSL added a commit that referenced this issue Jul 27, 2023
Sort printed options in --dump-config output.

Fixes: #64153

Reviewed By: carlosgalvezp

Differential Revision: https://reviews.llvm.org/D156452
eymay pushed a commit to eymay/llvm-project that referenced this issue Jul 28, 2023
Sort printed options in --dump-config output.

Fixes: llvm#64153

Reviewed By: carlosgalvezp

Differential Revision: https://reviews.llvm.org/D156452
eymay pushed a commit to eymay/llvm-project that referenced this issue Jul 28, 2023
Sort printed options in --dump-config output.

Fixes: llvm#64153

Reviewed By: carlosgalvezp

Differential Revision: https://reviews.llvm.org/D156452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang-tidy enhancement Improving things as opposed to bug fixing, e.g. new or missing feature
Projects
None yet
Development

No branches or pull requests

2 participants