Skip to content

[LVI][CVP] CVP error deleted the abs function #68682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dianqk opened this issue Oct 10, 2023 · 4 comments · Fixed by #68711 or llvm/llvm-project-release-prs#733
Closed

[LVI][CVP] CVP error deleted the abs function #68682

dianqk opened this issue Oct 10, 2023 · 4 comments · Fixed by #68711 or llvm/llvm-project-release-prs#733
Assignees
@dianqk
Labels
llvm:transforms miscompilation release:backport release:merged
Milestone
LLVM 17.0.X Release

Comments

@dianqk
Copy link
Member

dianqk commented Oct 10, 2023 •
edited
Loading

I tried this IR:

define i32 @constant_range_and_undef_2(i1 %c0, i1 %c1, i8 %v1) {
start:
  br i1 %c0, label %bb0, label %bb1

bb0:
  %v1_i32 = zext i8 %v1 to i32
  br label %bb1

bb1:
  %x = phi i32 [ %v1_i32, %bb0 ], [ undef, %start ]
  br i1 %c1, label %bb0, label %bb2

bb2:
  %z = call i32 @llvm.abs.i32(i32 %x, i1 false)
  ret i32 %z
}

abs should not be deleted by CVP.

alive2: https://alive2.llvm.org/ce/z/k_8paG.

Split issue from #68381.
@dianqk dianqk self-assigned this Oct 10, 2023
@dianqk dianqk changed the title [LVI][CVP] CVP error deleted the and function [LVI][CVP] CVP error deleted the abs function Oct 10, 2023
@dianqk dianqk mentioned this issue Oct 10, 2023
Merged
dianqk added a commit that referenced this issue Oct 15, 2023
@dianqk
[LVI][CVP] Treat undef like a full range on abs(x, false) (#68711)
2ad9a65 
Fixes #68682.
@dianqk
Copy link
Member Author

dianqk commented Oct 16, 2023

Reopening it, backport should make sense even if no known end-to-end miscompilations are found.

@dianqk dianqk reopened this Oct 16, 2023
@dianqk dianqk added this to the LLVM 17.0.X Release milestone Oct 16, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Oct 16, 2023
@dianqk
Copy link
Member Author

dianqk commented Oct 16, 2023

/cherry-pick 2ad9a65

@llvmbot
Copy link
Member

llvmbot commented Oct 16, 2023

/branch llvm/llvm-project-release-prs/issue68682

@llvmbot llvmbot mentioned this issue Oct 16, 2023
Merged
@llvmbot
Copy link
Member

llvmbot commented Oct 16, 2023

/pull-request llvm/llvm-project-release-prs#733

@tru tru moved this from Needs Triage to Needs Review in LLVM Release Status Oct 16, 2023
@tru tru moved this from Needs Review to Needs Merge in LLVM Release Status Oct 17, 2023
tru pushed a commit that referenced this issue Oct 24, 2023
@dianqk @tru
[LVI][CVP] Treat undef like a full range on abs(x, false) (#68711)
a710137 
Fixes #68682.

(cherry picked from commit 2ad9a65)
@tru tru moved this from Needs Merge to Done in LLVM Release Status Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dianqk dianqk

Labels
llvm:transforms miscompilation release:backport release:merged
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 17.0.X Release
3 participants
@EugeneZelenko @dianqk @llvmbot