Skip to content

[HLSL] implement SV_GroupID semantic #70120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #25
, #255 ,  #20
...
llvm-beanz opened this issue Oct 24, 2023 · 3 comments · Fixed by #115911
Closed
Tracked by #25
, #255 ,  #20
...

[HLSL] implement SV_GroupID semantic #70120

llvm-beanz opened this issue Oct 24, 2023 · 3 comments · Fixed by #115911
Assignees
@lizhengxing
Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@llvm-beanz
Copy link
Collaborator

llvm-beanz commented Oct 24, 2023 •
edited by davidcook-msft
Loading

Implement the HLSL SV_GroupID semantic for entry parameter declarations:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sv-groupid

AC:

  • Implement through to code generation
  • Can print the AST to verify the generation
@llvm-beanz llvm-beanz converted this from a draft issue Oct 24, 2023
@llvm-beanz llvm-beanz added the HLSL HLSL Language Support label Oct 24, 2023
@lizhengxing
Copy link
Contributor

I'll work on this task.

@damyanp damyanp moved this to Active in HLSL Support Oct 9, 2024
@damyanp damyanp moved this from Active to Ready in HLSL Support Oct 24, 2024
@damyanp damyanp moved this from Ready to Active in HLSL Support Nov 8, 2024
@lizhengxing lizhengxing mentioned this issue Nov 12, 2024
Merged
lizhengxing added a commit to lizhengxing/llvm-project that referenced this issue Nov 12, 2024
@lizhengxing
[HLSL] Implement SV_GroupID semantic
6418461 
Support SV_GroupID attribute.
Translate it into dx.group.id in clang codeGen.

Fixes: llvm#70120
@damyanp damyanp moved this from Active to Needs Review in HLSL Support Nov 12, 2024
@tex3d tex3d closed this as completed in 5fd4f32 Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Nov 26, 2024
@EugeneZelenko EugeneZelenko added clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:codegen IR generation bugs: mangling, exceptions, etc. labels Nov 26, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 26, 2024

@llvm/issue-subscribers-clang-frontend

Author: Chris B (llvm-beanz)

Implement the HLSL `SV_GroupID` semantic for entry parameter declarations:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sv-groupid

AC:

  • Implement through to code generation
  • Can print the AST to verify the generation

@llvmbot
Copy link
Member

llvmbot commented Nov 26, 2024

@llvm/issue-subscribers-clang-codegen

Author: Chris B (llvm-beanz)

Implement the HLSL `SV_GroupID` semantic for entry parameter declarations:

https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sv-groupid

AC:

  • Implement through to code generation
  • Can print the AST to verify the generation

@llvm-beanz llvm-beanz mentioned this issue Dec 4, 2024
Closed
@lizhengxing lizhengxing mentioned this issue Dec 5, 2024
Merged
@lizhengxing lizhengxing mentioned this issue Jan 2, 2025
Merged
lizhengxing added a commit to lizhengxing/llvm-project that referenced this issue Jan 2, 2025
@lizhengxing
[HLSL][SPIR-V] implement SV_GroupID semantic lowering
21114c4 
The HLSL SV_GroupID semantic attribute is lowered into @llvm.spv.group.id intrinsic in LLVM IR for SPIR-V target.

In the SPIR-V backend, this is now translated to a `WorkgroupId` builtin variable.

Fixes llvm#118700 which's a follow-up work to llvm#70120
lizhengxing added a commit that referenced this issue Jan 4, 2025
@lizhengxing
[HLSL][SPIR-V] implement SV_GroupID semantic lowering (#121521)
7a76110 
The HLSL SV_GroupID semantic attribute is lowered into
@llvm.spv.group.id intrinsic in LLVM IR for SPIR-V target.

In the SPIR-V backend, this is now translated to a `WorkgroupId` builtin
variable.

Fixes #118700 which's a follow-up work to #70120
This was referenced Feb 8, 2025
Open
Closed
@farzonl farzonl mentioned this issue Apr 25, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizhengxing lizhengxing

Labels
clang:codegen IR generation bugs: mangling, exceptions, etc. clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] Implement SV_GroupID semantic lizhengxing/llvm-project
4 participants
@EugeneZelenko @lizhengxing @llvm-beanz @llvmbot