Skip to content

Miscompile after f5687636415969e6d945659a0b78734abdfb0f06 #76202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vitalybuka opened this issue Dec 22, 2023 · 9 comments · Fixed by #79951
Open

Miscompile after f5687636415969e6d945659a0b78734abdfb0f06 #76202

vitalybuka opened this issue Dec 22, 2023 · 9 comments · Fixed by #79951
Assignees
@vfdff
Labels
backend:AArch64 miscompilation

Comments

@vitalybuka
Copy link
Collaborator

vitalybuka commented Dec 22, 2023 •
edited
Loading

https://lab.llvm.org/buildbot/#/builders/238/builds/7108
@vitalybuka
Copy link
Collaborator Author

vitalybuka commented Dec 22, 2023 •
edited
Loading

Local bisect points to f568763.

vitalybuka added a commit that referenced this issue Dec 22, 2023
@vitalybuka
Revert "[AArch64] Fold more load.x into load.i with large offset"
0ccc1e7 
Issue #76202

This reverts commit f568763.
@llvmbot
Copy link
Member

llvmbot commented Dec 22, 2023

@llvm/issue-subscribers-backend-aarch64

Author: Vitaly Buka (vitalybuka)

https://lab.llvm.org/buildbot/#/builders/238/builds/7108

vitalybuka referenced this issue Dec 22, 2023
@vfdff
[AArch64] Fold more load.x into load.i with large offset
f568763 
The list of load.x is refer to canFoldIntoAddrMode on D152828.
Also support LDRSroX missed in canFoldIntoAddrMode
@vfdff
Copy link
Contributor

vfdff commented Dec 22, 2023 •
edited
Loading

hi @vitalybuka would your please give me some advice on how to reproduce the issue ?
I can't see any valid info from above link, does any extra right required?

@vfdff vfdff mentioned this issue Dec 22, 2023
Closed
@vfdff
Copy link
Contributor

vfdff commented Dec 25, 2023

ping @vitalybuka ?

@vitalybuka
Copy link
Collaborator Author

You probably can follow https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild on GCE ARM machine

This is UBSAN, so maybe even QEMU is enough.

davemgreen added a commit that referenced this issue Jan 28, 2024
@davemgreen
Revert "[AArch64] merge index address with large offset into base add…
915c3d9 
…ress"

This reverts commit 32878c2 due to #79756 and #76202.
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Jan 29, 2024
@davemgreen @llvmbot
Revert "[AArch64] merge index address with large offset into base add…
2ca4515 
…ress"

This reverts commit 32878c2 due to llvm#79756 and llvm#76202.

(cherry picked from commit 915c3d9)
tstellar pushed a commit that referenced this issue Jan 29, 2024
@davemgreen @tstellar
Revert "[AArch64] merge index address with large offset into base add…
bab01ae 
…ress"

This reverts commit 32878c2 due to #79756 and #76202.

(cherry picked from commit 915c3d9)
@davemgreen davemgreen mentioned this issue Jan 31, 2024
Merged
tstellar pushed a commit to tstellar/llvm-project that referenced this issue Feb 14, 2024
@davemgreen @tstellar
Revert "[AArch64] merge index address with large offset into base add…
672265e 
…ress"

This reverts commit 32878c2 due to llvm#79756 and llvm#76202.

(cherry picked from commit 915c3d9)
tstellar pushed a commit to tstellar/llvm-project that referenced this issue Feb 14, 2024
@davemgreen @tstellar
Revert "[AArch64] merge index address with large offset into base add…
c51ec48 
…ress"

This reverts commit 32878c2 due to llvm#79756 and llvm#76202.

(cherry picked from commit 915c3d9)
tstellar pushed a commit to tstellar/llvm-project that referenced this issue Feb 14, 2024
@davemgreen @tstellar
Revert "[AArch64] merge index address with large offset into base add…
899d834 
…ress"

This reverts commit 32878c2 due to llvm#79756 and llvm#76202.

(cherry picked from commit 915c3d9)
tstellar pushed a commit to tstellar/llvm-project that referenced this issue Feb 14, 2024
@davemgreen @tstellar
Revert "[AArch64] merge index address with large offset into base add…
d95dbc2 
…ress"

This reverts commit 32878c2 due to llvm#79756 and llvm#76202.

(cherry picked from commit 915c3d9)
@vfdff
Copy link
Contributor

vfdff commented May 21, 2024 •
edited
Loading

hi @vitalybuka, As I can't reproduce your issue, and now with extra commit 46ea6571 on #79951, I've been testing our downstream branch for some time and have found no new issues. so would you help me check this also fix the runtime issue you reported ?

@vfdff
Copy link
Contributor

vfdff commented May 27, 2024

sorry for trouble!

@vitalybuka
Copy link
Collaborator Author

Unfortunately link to bot is expired, I am not sure which one was broken.
I added msan recently, but it was incorrect. I tried to reproduce f568763 to be sure, but bots are newer linux, and it fails with unrelated mmap error. To pass that error to reach miscompile I need to downgrade bots, which it to much effor. I will try to run #79951 on head and see if it's still broken.

@vitalybuka
Copy link
Collaborator Author

vitalybuka commented Aug 19, 2024 •
edited
Loading

Reverted with 43ffe2e
details are here #79951

@vitalybuka vitalybuka reopened this Aug 19, 2024
vfdff added a commit to vfdff/llvm-project that referenced this issue Aug 26, 2024
@vfdff
[AArch64] Fix buildbot breakage of ubsan
055f935 
Fix the ERROR: UndefinedBehaviorSanitizer, reproduced by
  BUILDBOT_REVISION=43ffe2eed llvm-zorg/zorg/buildbot/builders/sanitizers/buildbot_bootstrap_ubsan.sh
It might be also related to llvm#76202
@vfdff vfdff mentioned this issue Aug 26, 2024
Merged
vfdff added a commit to vfdff/llvm-project that referenced this issue Aug 28, 2024
@vfdff
[AArch64] Fix buildbot breakage of ubsan
8067b88 
Fix the ERROR: UndefinedBehaviorSanitizer, reproduced by
  BUILDBOT_REVISION=43ffe2eed llvm-zorg/zorg/buildbot/builders/sanitizers/buildbot_bootstrap_ubsan.sh
It might be also related to llvm#76202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vfdff vfdff

Labels
backend:AArch64 miscompilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AArch64] Reland merge index address with large offset into base address vfdff/llvm-project
4 participants
@vitalybuka @vfdff @EugeneZelenko @llvmbot