-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Simplify sinh(x) / cosh(x) -> tanh(x) with fast-math #78871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey is anyone working on this ? If not could someone assign this to me ? |
No one's replied till now (5 days since issue filing), so I'll assume no one has picked this up. |
#77799 also related |
Thanks for assigning me, I will look into this as soon as possible |
I am almost done with this but there is one thing I can't quite figure out. I used |
The replaceInstUsesWith only replaces the uses, leaving behind the dead call instructions. You need to separately erase them |
It seems that the simplification
sin(x) / cos(x) -> tan(x)
has been already implemented, but the same applies for hyperbolic function(s).https://godbolt.org/z/WqYfKxr7K
For those who are interested in floating-point arithmetic optimization, I think this can be added to #34959.
The text was updated successfully, but these errors were encountered: