-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Enable epoll_pwait2 only when the syscall is available #80060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@llvm/issue-subscribers-libc Author: None (michaelrj-google)
Had to be disabled here: https://github.com//pull/80051
We should enable it on systems that have the syscall, perhaps put this into excludes along with a compile check? |
Adding additional context: The |
This patch reverts llvm#99781 and part of llvm#99771 since `epoll_pwait2` is not in fact available on all supported systems. It is my opinion that we shouldn't provide a version of a function that doesn't perform as expected, which is why this revert needs to happen. The `epoll_pwait2` function can be reenabled when we have a way to check if it is available on the target system, tracking bug for that is llvm#80060
This patch reverts #99781 and part of #99771 since `epoll_pwait2` is not in fact available on all supported systems. It is my opinion that we shouldn't provide a version of a function that doesn't perform as expected, which is why this revert needs to happen. The `epoll_pwait2` function can be reenabled when we have a way to check if it is available on the target system, tracking bug for that is #80060
This patch reverts #99781 and part of #99771 since `epoll_pwait2` is not in fact available on all supported systems. It is my opinion that we shouldn't provide a version of a function that doesn't perform as expected, which is why this revert needs to happen. The `epoll_pwait2` function can be reenabled when we have a way to check if it is available on the target system, tracking bug for that is #80060
Wont the kernel fail with |
And the unit tests should handle the ENOSYS case. |
The kernel should fail with |
Had to be disabled here: #80051
We should enable it on systems that have the syscall, perhaps put this into excludes along with a compile check?
The text was updated successfully, but these errors were encountered: