Skip to content

Github workflow misattributes /cherry-pick backport request comment #82580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrick-rivos opened this issue Feb 22, 2024 · 2 comments · Fixed by #82680
Closed

Github workflow misattributes /cherry-pick backport request comment #82580

patrick-rivos opened this issue Feb 22, 2024 · 2 comments · Fixed by #82680
Assignees
@tstellar
Labels
github:workflow

Comments

@patrick-rivos
Copy link
Contributor

Request: #82430 (comment)
Misattributed to me: #82572

Current workflow:

llvm-project/.github/workflows/issue-release-workflow.yml

Line 68 in 815644b

--requested-by ${{ github.event.issue.user.login }} \

Replacing this line with ${{ github.event.comment.user.login }} would attribute the PR to the user that commented /cherry-pick

From looking at the workflow it looks like it supports cherry-pick in newly opened issues too. Replacing the .issue with .comment won't work in that case, so issues/comments need to have different logic to attribute properly in all cases.
@tstellar tstellar self-assigned this Feb 22, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 22, 2024

Request: #82430 (comment)
Misattributed to me: #82572

Current workflow:

llvm-project/.github/workflows/issue-release-workflow.yml

Line 68 in 815644b

--requested-by ${{ github.event.issue.user.login }} \

Replacing this line with ${{ github.event.comment.user.login }} would attribute the PR to the user that commented /cherry-pick

From looking at the workflow it looks like it supports cherry-pick in newly opened issues too. Replacing the .issue with .comment won't work in that case, so issues/comments need to have different logic to attribute properly in all cases.

Error: Command failed due to missing milestone.

@lukel97
Copy link
Contributor

lukel97 commented Feb 22, 2024

I noticed this too, thanks for filing this!

@tstellar tstellar mentioned this issue Feb 22, 2024
Merged
tstellar added a commit to tstellar/llvm-project that referenced this issue Feb 23, 2024
@tstellar
[workflows] Mention the correct user who makes a /cherry-pick comment
493e75a 
We were mentioning the creator of the issue with the comment rather than
the creator of the comment.

Fixes llvm#82580
tstellar added a commit that referenced this issue Mar 9, 2024
@tstellar
[workflows] Mention the correct user who makes a /cherry-pick comment (…
0be1c3b 
…#82680)

We were mentioning the creator of the issue with the comment rather than
the creator of the comment.

Fixes #82580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
github:workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[workflows] Mention the correct user who makes a /cherry-pick comment tstellar/llvm-project
5 participants
@tstellar @lukel97 @EugeneZelenko @llvmbot @patrick-rivos