Skip to content

remove rcp intrinsic and move lowering out of DXILIntrinsicExpansion.cpp and into CGBuiltin.cpp #87784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
farzonl opened this issue Apr 5, 2024 · 1 comment · Fixed by #88401
Closed

remove rcp intrinsic and move lowering out of DXILIntrinsicExpansion.cpp and into CGBuiltin.cpp #87784

farzonl opened this issue Apr 5, 2024 · 1 comment · Fixed by #88401
Assignees
@farzonl
Labels
backend:DirectX clang:codegen IR generation bugs: mangling, exceptions, etc.

Comments

@farzonl
Copy link
Member

farzonl commented Apr 5, 2024

SPIRV and DXIL both lower to 1/x so an intrinsic isn't necessary.

Originally posted by @farzonl in #87367 (comment)
@farzonl farzonl self-assigned this Apr 11, 2024
@farzonl farzonl mentioned this issue Apr 11, 2024
Merged
@farzonl farzonl moved this to Active in HLSL Support Apr 11, 2024
farzonl added a commit that referenced this issue Apr 11, 2024
@farzonl
[HLSL] move rcp to cgbuiltins (#88401)
4036a69 
Removing the intrinsic because there is no opCodes for rcp in DXIL or
SPIR-V.
Moving means we don't have to re-implement this feature for each
backend.

fixes #87784

Co-authored-by: Farzon Lotfi <[email protected]>
@github-project-automation github-project-automation bot moved this from Active to Done in HLSL Support Apr 11, 2024
@EugeneZelenko EugeneZelenko added the clang:codegen IR generation bugs: mangling, exceptions, etc. label Apr 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 11, 2024

@llvm/issue-subscribers-clang-codegen

Author: Farzon Lotfi (farzonl)

SPIRV and DXIL both lower to `1/x` so an intrinsic isn't necessary.

Originally posted by @farzonl in #87367 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farzonl farzonl

Labels
backend:DirectX clang:codegen IR generation bugs: mangling, exceptions, etc.
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] move rcp to cgbuiltins farzonl/llvm-project
3 participants
@farzonl @EugeneZelenko @llvmbot