Skip to content

Add arm64 support for tan to cover f16 cases in a major isa #94755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
farzonl opened this issue Jun 7, 2024 · 1 comment · Fixed by #94545
Closed

Add arm64 support for tan to cover f16 cases in a major isa #94755

farzonl opened this issue Jun 7, 2024 · 1 comment · Fixed by #94545
Assignees
@farzonl
Labels
backend:AArch64

Comments

@farzonl
Copy link
Member

farzonl commented Jun 7, 2024

No description provided.

@farzonl farzonl self-assigned this Jun 7, 2024
@farzonl farzonl converted this from a draft issue Jun 7, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 7, 2024

@llvm/issue-subscribers-backend-aarch64

Author: Farzon Lotfi (farzonl)

@farzonl farzonl removed the new issue label Jun 7, 2024
@farzonl farzonl mentioned this issue Jun 7, 2024
Merged
farzonl added a commit that referenced this issue Jun 7, 2024
@farzonl
[arm64] Add tan intrinsic lowering (#94545)
2f0308e 
This change is an implementation of
#87367 investigation on
supporting IEEE math operations as intrinsics.
Which was discussed in this RFC:
https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294

This PR is just for Tan.

Now that x86 tan backend landed:
#90503 we can add other
backends since the shared pieces are in tree now.

Changes:
- `llvm/include/llvm/Analysis/VecFuncs.def` - vectorization of tan for
arm64 backends.
- `llvm/lib/Target/AArch64/AArch64FastISel.cpp` - Add tan to the libcall
table
- `llvm/lib/Target/AArch64/AArch64ISelLowering.cpp` - Add tan expansion
for f128, f16, and vector\neon operations
- `llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp` define
`G_FTAN` as a legal arm64 instruction

resolves #94755
@github-project-automation github-project-automation bot moved this from Active to Done in HLSL Support Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farzonl farzonl

Labels
backend:AArch64
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[arm64] Add tan intrinsic lowering farzonl/llvm-project
2 participants
@farzonl @llvmbot