Skip to content

Implement the IgnoreHit HLSL Function #99181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 0 comments
Open
12 tasks
Tracked by #99235

Implement the IgnoreHit HLSL Function #99181

farzonl opened this issue Jul 16, 2024 · 0 comments
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement IgnoreHit clang builtin,
  • Link IgnoreHit clang builtin with hlsl_intrinsics.h
  • Add sema checks for IgnoreHit to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for IgnoreHit to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/IgnoreHit.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/IgnoreHit-errors.hlsl
  • Create the int_dx_IgnoreHit intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_IgnoreHit to 155 in DXIL.td
  • Create the IgnoreHit.ll and IgnoreHit_errors.ll tests in llvm/test/CodeGen/DirectX/
  • Create the int_spv_IgnoreHit intrinsic in IntrinsicsSPIRV.td
  • In SPIRVInstructionSelector.cpp create the IgnoreHit lowering and map it to int_spv_IgnoreHit in SPIRVInstructionSelector::selectIntrinsic.
  • Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/IgnoreHit.ll

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
155 IgnoreHit 6.3 ('anyhit',)

SPIR-V

OpIgnoreIntersectionKHR:

Description:

Reserved.

Capability:
RayTracingKHR

Reserved.

Word Count Opcode Results Operands
1 4448

Test Case(s)

Example 1

//dxc IgnoreHit_test.hlsl -T lib_6_8 -enable-16bit-types -O0

struct [raypayload] RayPayload
{
	float4 color : write(caller) : read(anyhit);
	float distance : write(caller) : read(anyhit);
};

struct Attributes {
	float3 barycentrics;
	uint primitiveIndex;
};

[shader("anyhit")]
export void fn(inout RayPayload payload, in Attributes attributes) {
	return IgnoreHit();
}

SPIRV Example(s):

Example 2

//dxc IgnoreHit_spirv_test.hlsl -T lib_6_8 -E fn -enable-16bit-types -spirv -fspv-target-env=universal1.5 -fcgl -O0

struct [raypayload] RayPayload
{
	float4 color : write(caller) : read(anyhit);
	float distance : write(caller) : read(anyhit);
};

struct Attributes {
	float3 barycentrics;
	uint primitiveIndex;
};

[shader("anyhit")]
void fn(inout RayPayload payload, in Attributes attributes) {
	return IgnoreHit();
}

HLSL:

Called from an any hit shader to reject the hit and end the shader. The hit search continues on without committing the distance and attributes for the current hit. The ReportHit call in the intersection shader, if there is one, will return false. Any modifications made to the ray payload up to this point in the any hit shader are preserved.

Syntax

void IgnoreHit();

Return Value

void

Remarks

This function can be called from the following raytracing shader types:

See also

Direct3D 12 Raytracing HLSL Reference

@farzonl farzonl added backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Planning to Designing in HLSL Support Nov 26, 2024
@damyanp damyanp removed the status in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: No status
Development

No branches or pull requests

1 participant