[LLDB] Remove decorator from XPASSes x86/Windows #100628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch remove XFAIL decorator from tests which are passing on x86 Windows. Corresponding XFAILs for AArch64 were removed here 7daa9a9.
|
@llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) ChangesThis patch remove XFAIL decorator from tests which are passing on x86 Windows. Corresponding XFAILs for AArch64 were removed here 7daa9a9. Full diff: https://github.com/llvm/llvm-project/pull/100628.diff 2 Files Affected:
diff --git a/lldb/test/API/lang/cpp/class-template-non-type-parameter-pack/TestClassTemplateNonTypeParameterPack.py b/lldb/test/API/lang/cpp/class-template-non-type-parameter-pack/TestClassTemplateNonTypeParameterPack.py
index 9e484e0132c83..730537da2fccf 100644
--- a/lldb/test/API/lang/cpp/class-template-non-type-parameter-pack/TestClassTemplateNonTypeParameterPack.py
+++ b/lldb/test/API/lang/cpp/class-template-non-type-parameter-pack/TestClassTemplateNonTypeParameterPack.py
@@ -5,9 +5,6 @@
class TestCaseClassTemplateNonTypeParameterPack(TestBase):
- @expectedFailureAll(
- oslist=["windows"], archs=["i[3-6]86", "x86_64"]
- ) # Fails to read memory from target.
@no_debug_info_test
def test(self):
self.build()
diff --git a/lldb/test/API/lang/cpp/class-template-type-parameter-pack/TestClassTemplateTypeParameterPack.py b/lldb/test/API/lang/cpp/class-template-type-parameter-pack/TestClassTemplateTypeParameterPack.py
index 102c00dc603df..1ed643e6dd85c 100644
--- a/lldb/test/API/lang/cpp/class-template-type-parameter-pack/TestClassTemplateTypeParameterPack.py
+++ b/lldb/test/API/lang/cpp/class-template-type-parameter-pack/TestClassTemplateTypeParameterPack.py
@@ -5,9 +5,6 @@
class TestCaseClassTemplateTypeParameterPack(TestBase):
- @expectedFailureAll(
- oslist=["windows"], archs=["i[3-6]86", "x86_64"]
- ) # Fails to read memory from target.
@no_debug_info_test
def test(self):
self.build()
|
kendalharland
pushed a commit
to kendalharland/llvm-project
that referenced
this pull request
Aug 8, 2024
weliveindetail
pushed a commit
to weliveindetail/llvm-project
that referenced
this pull request
Dec 2, 2024
This patch removes XFAIL decorators from tests that are passing on x86 Windows. Corresponding XFAILs for AArch64 were removed here 7daa9a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes XFAIL decorators from tests that are passing on x86 Windows.
Corresponding XFAILs for AArch64 were removed here 7daa9a9.