-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[SCEV] Add predicate in SolveLinEq to ensure B is a multiple of A. #108777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c91b942
[SCEV] Add predicate in SolveLinEq to ensure B is a multiple of A.
fhahn 2832a8a
Merge remote-tracking branch 'origin/main' into scev-align-predicate
fhahn fcf36c4
!fixup Address latest comments, thanks!
fhahn f23bddc
Merge remote-tracking branch 'origin/main' into scev-align-predicate
fhahn c312060
!fixup update and assert.
fhahn d6522f9
!fixup use APInt::getOneBitSet, thanks!
fhahn 7624c7d
Merge remote-tracking branch 'origin/main' into scev-align-predicate
fhahn f648176
Merge remote-tracking branch 'origin/main' into scev-align-predicate
fhahn e36de7d
!fixup replace assertion with check
fhahn ee755af
!fixup update thumb test
fhahn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe try to prove that (urem B, A) == 0 before resorting to the predicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC that check shouldn't be true, otherwise we are missing some logic in
getMinTrailingZeros
? Added an assert that the check isn't true.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the reframing of urem (B, 1 << Mult2) == 0, I agree with your comment, but I think we could reasonable see divergence with the original urem(B,A) check. Those are just different enough.
My suggestion is basically, can we prove the original fact without using the trailing bits proof strategy? Said differently. what if D = gcd(A, N) is something like 3^M?
Hm, though now I see that the multiplicative inverse code below would need updated too. I'd missed that originally.
(Totally fine to move forward here, this is purely a possible followup.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stand corrected, the assertion actually uncovered a case where getMinTrailingZeros returns a worse result and I think catching this in getMinTrailingZeros would require matching a specific pattern (https://alive2.llvm.org/ce/z/t3A5X2)
I updated the code to check if the URem is zero if the trailing bits check failed, as we need to build the expression there already. Test is in
llvm/test/Analysis/ScalarEvolution/trip-count-urem.ll