Skip to content

[WebAssembly] Add indentations to annotations.s #108790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Sep 16, 2024

Given that the instructions here are all control flow instructions, adding indentations seem to make it easier to read.

Given that the instructions here are all control flow instructions,
adding indentations seem to make it easier to read.
@aheejin aheejin requested a review from dschuff September 16, 2024 04:24
@llvmbot llvmbot added backend:WebAssembly mc Machine (object) code labels Sep 16, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2024

@llvm/pr-subscribers-mc

@llvm/pr-subscribers-backend-webassembly

Author: Heejin Ahn (aheejin)

Changes

Given that the instructions here are all control flow instructions, adding indentations seem to make it easier to read.


Full diff: https://github.com/llvm/llvm-project/pull/108790.diff

1 Files Affected:

  • (modified) llvm/test/MC/WebAssembly/annotations.s (+21-21)
diff --git a/llvm/test/MC/WebAssembly/annotations.s b/llvm/test/MC/WebAssembly/annotations.s
index 18fd16f2dc687b..b1f97daccccd65 100644
--- a/llvm/test/MC/WebAssembly/annotations.s
+++ b/llvm/test/MC/WebAssembly/annotations.s
@@ -10,28 +10,28 @@ test_annotation:
   .functype   test_annotation () -> ()
   .tagtype  __cpp_exception i32
   try
-  br        0
+    br        0
   catch     __cpp_exception
-  block
-  br_if     0
-  loop
-  br_if     1
-  end_loop
-  end_block
-  try
-  rethrow   0
-  catch     __cpp_exception
-  catch_all
-  block
-  try
-  br        0
-  try
-  delegate  1
-  catch_all
-  end_try
-  end_block
-  rethrow   0
-  end_try
+    block
+      br_if     0
+      loop
+        br_if     1
+      end_loop
+    end_block
+    try
+      rethrow   0
+    catch     __cpp_exception
+    catch_all
+      block
+        try
+          br        0
+          try
+          delegate  1
+        catch_all
+        end_try
+      end_block
+      rethrow   0
+    end_try
   end_try
   end_function
 

@aheejin aheejin merged commit d8ee96c into llvm:main Sep 16, 2024
14 checks passed
@aheejin aheejin deleted the annotation_indent branch September 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:WebAssembly mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants