Skip to content

[NVPTX] Prefer prmt.b32 over bfi.b32 #110766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[NVPTX] Prefer prmt.b32 over bfi.b32 #110766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52a1db5
Initial commit
justinfargnoli Sep 25, 2024
8b9c99f
Update sext-setcc.ll
justinfargnoli Sep 25, 2024
5b1853f
prmt(d, prmt(c, prmt(a,b))) --> prmt(prmt(c,d), prmt(a,b))
justinfargnoli Oct 4, 2024
6c3197c
clang-format
justinfargnoli Oct 4, 2024
eb105b4
Update tests
justinfargnoli Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,20 +2328,23 @@ SDValue NVPTXTargetLowering::LowerBUILD_VECTOR(SDValue Op,
// Lower non-const v4i8 vector as byte-wise constructed i32, which allows us
// to optimize calculation of constant parts.
if (VT == MVT::v4i8) {
SDValue C8 = DAG.getConstant(8, DL, MVT::i32);
SDValue E01 = DAG.getNode(
NVPTXISD::BFI, DL, MVT::i32,
DAG.getAnyExtOrTrunc(Op->getOperand(1), DL, MVT::i32),
DAG.getAnyExtOrTrunc(Op->getOperand(0), DL, MVT::i32), C8, C8);
SDValue E012 =
DAG.getNode(NVPTXISD::BFI, DL, MVT::i32,
DAG.getAnyExtOrTrunc(Op->getOperand(2), DL, MVT::i32),
E01, DAG.getConstant(16, DL, MVT::i32), C8);
SDValue E0123 =
DAG.getNode(NVPTXISD::BFI, DL, MVT::i32,
DAG.getAnyExtOrTrunc(Op->getOperand(3), DL, MVT::i32),
E012, DAG.getConstant(24, DL, MVT::i32), C8);
return DAG.getNode(ISD::BITCAST, DL, VT, E0123);
SDValue PRMT__10 = DAG.getNode(
NVPTXISD::PRMT, DL, MVT::v4i8,
{DAG.getAnyExtOrTrunc(Op->getOperand(0), DL, MVT::i32),
DAG.getAnyExtOrTrunc(Op->getOperand(1), DL, MVT::i32),
DAG.getConstant(0x3340, DL, MVT::i32),
DAG.getConstant(NVPTX::PTXPrmtMode::NONE, DL, MVT::i32)});
SDValue PRMT32__ = DAG.getNode(
NVPTXISD::PRMT, DL, MVT::v4i8,
{DAG.getAnyExtOrTrunc(Op->getOperand(2), DL, MVT::i32),
DAG.getAnyExtOrTrunc(Op->getOperand(3), DL, MVT::i32),
DAG.getConstant(0x4033, DL, MVT::i32),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the mode here needs to be 0x3340, then our tests pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinfargnoli for visibility

DAG.getConstant(NVPTX::PTXPrmtMode::NONE, DL, MVT::i32)});
SDValue PRMT3210 = DAG.getNode(
NVPTXISD::PRMT, DL, MVT::v4i8,
{PRMT__10, PRMT32__, DAG.getConstant(0x5410, DL, MVT::i32),
DAG.getConstant(NVPTX::PTXPrmtMode::NONE, DL, MVT::i32)});
return DAG.getNode(ISD::BITCAST, DL, VT, PRMT3210);
}
return Op;
}
Expand Down
Loading
Loading